Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let css keyframes name accept string #13965

Closed
wants to merge 1 commit into from

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 7, 2018

A @Keyframes block has a name given by the <custom-ident> or <string>
in its prelude. The two syntaxes are equivalent in functionality;
the name is the value of the ident or string[1].
[1]: https://drafts.csswg.org/css-animations/#typedef-keyframes-name

Bug: 882286
Change-Id: I2e9531beb17e38699dd0c535ae03f0bb16638227

Reviewed-on: https://chromium-review.googlesource.com/1322260
WPT-Export-Revision: 52dec894946c86660798a223140329481d5513db

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

A @Keyframes block has a name given by the <custom-ident> or <string>
in its prelude. The two syntaxes are equivalent in functionality;
the name is the value of the ident or string[1].
[1]: https://drafts.csswg.org/css-animations/#typedef-keyframes-name

Bug: 882286
Change-Id: I2e9531beb17e38699dd0c535ae03f0bb16638227
@gsnedders gsnedders closed this Jan 24, 2020
@gsnedders gsnedders deleted the chromium-export-cl-1322260 branch January 24, 2020 18:02
@gsnedders gsnedders restored the chromium-export-cl-1322260 branch January 24, 2020 18:42
@Hexcles Hexcles reopened this Jan 24, 2020
@KyleJu KyleJu closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants