Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG Geometry: computed value of properties #14075

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

ewilligers
Copy link
Contributor

cx cy r rx ry x y computed values are lengths or percentages.

@ewilligers
Copy link
Contributor Author

@foolip - this is a similar failure to #13951: "No output has been received in the last 10m0s".

Are others experiencing this too?

cx cy r rx ry x y computed values are lengths or percentages.
https://svgwg.org/svg2-draft/geometry.html
@foolip
Copy link
Member

foolip commented Nov 16, 2018

@ewilligers unfortunately yes, you're not the only one affected by this. I've just sent #14096 to make stability jobs on Travis non-blocking until we remove them entirely.

I'll admin merge this.

@foolip foolip merged commit 39c2331 into web-platform-tests:master Nov 16, 2018
@ewilligers ewilligers deleted the geometry-computed branch November 16, 2018 13:39
@longsonr
Copy link
Contributor

test_computed_value("cy", "calc(50% + 60x)");

Is that a typo for 60px?

@ewilligers
Copy link
Contributor Author

test_computed_value("cy", "calc(50% + 60x)");

Is that a typo for 60px?

Yes, sorry.

Note that when the test is fixed, Blink fails with

FAIL Property y value 'calc(50% + 60px)' computes to 'calc(50% + 60px)' assert_equals: expected "calc(50% + 60px)" but got "calc(60px + 50%)"

We should also have calc(em - px) tests that results in negatives, so see if r rx ry clamp computed values to 0, while cx cy x y are not clamped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants