Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timeout in async_test for html tests #14087

Merged
merged 2 commits into from
Nov 22, 2018

Conversation

qiuzhong
Copy link
Contributor

Remove all the timeout in async_test for html tests.
Affected tests: 125
Before: Pass: 64, Failed: 61
After: Pass: 64, Failed: 61
Related: #11120

@foolip
Copy link
Member

foolip commented Nov 16, 2018

Travis has failed because "No output has been received in the last 10m0s". However, wpt-chrome-dev-stability and wpt-firefox-nightly-stability on Taskcluster passed, so at least the tests aren't flaky.

I do wonder if any of them are slow though. Looking at https://queue.taskcluster.net/v1/task/Vw3E0As5R1W9TebRCNcLxQ/runs/0/artifacts/public/results/wpt_report.json.gz I see that /html/browsers/browsing-the-web/navigating-across-documents/010.html took 15 seconds. @qiuzhong, can you check if any other tests are made slow, and was that test in particular made slower with this change?

@jdm
Copy link
Contributor

jdm commented Nov 16, 2018

I saw those "no output" errors on several of the PRs removing the test-specific timeout values.

@jgraham
Copy link
Contributor

jgraham commented Nov 16, 2018

It happens more now because we filtered out a lot of the process output from Firefox in order to avoid overflowing the logs, but the flip side is we experience more timeouts. If we wanted to fix it we'd presumably have to arrange for a periodic ping to be logged.

@foolip
Copy link
Member

foolip commented Nov 16, 2018

With #14096 merged it should be possible to just rebase this or otherwise retrigger checks.

Remove all the timeout in `async_test` for html tests.
Affected tests: 125
Before: Pass: 64, Failed: 61
After:  Pass: 64, Failed: 61
Related: web-platform-tests#11120
@qiuzhong qiuzhong force-pushed the remove-timeout-html branch from 19e5d31 to cb656d1 Compare November 19, 2018 06:34
@qiuzhong
Copy link
Contributor Author

Found lots of errors like this:

Traceback (most recent call last):
  File "/home/test/web-platform-tests/tools/wptserve/wptserve/handlers.py", line 310, in __call__
    rv = self.func(request, response)
  File "/home/test/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/cors/support/cors-tester.py", line 36, in main
    line = 'cors = ' + cors + ' | cookie = ' + cookie.value;
AttributeError: 'str' object has no attribute 'value'

@@ -6,7 +6,7 @@
<pre id="step_log"></pre>
<iframe id="test"></iframe>
<script>
var t = async_test(undefined, {timeout:10000});
var t = async_test(undefined);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove the undefined arguments? They were only there to make it possible to pass in the second argument.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'll remove all of them.

After remove the timeout parameter from async_test, the first parameter
`undefined` is no use and should be removed.
@foolip foolip merged commit 1f92ddd into web-platform-tests:master Nov 22, 2018
@foolip
Copy link
Member

foolip commented Nov 22, 2018

Thanks @qiuzhong, one down, a few more PRs to go :)

@foolip
Copy link
Member

foolip commented Nov 23, 2018

https://tools.taskcluster.net/groups/DWgMz-OFQOKp5iktSe1gSg unfortunately failed so a clean before/after diff view for this PR isn't possible.

@foolip
Copy link
Member

foolip commented Nov 23, 2018

Filed #14207 for the fact that Taskcluster is failing. Once there's another working run I'll compare, but then more changes will be lumped in.

@foolip
Copy link
Member

foolip commented Nov 23, 2018

Ah, but iframe_sandbox_popups_escaping-1.html wasn't modified, so that's probably a flaky test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants