[FileAPI] Remove reference to non-existent file #14132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file `FileAPI/url/url-with-tags.window.js` is not currently present in the repository nor was it present when the reference was introduced [1]. Remove it to avoid triggering spurious request failures during test execution. [1] 9d8a185
|
Got it. I've added a reference to that file via another commit. The commit message will have to be updated, but before that, we have an instability on our hands. Bisecting indicates that it's a wptrunner regression from 31664a8, which was merged via gh-13419. A newer wptrunner patch is currently under review, and as luck would have it, it fixes this problem. This change should pass the stability checks once that patch is merged. |
This was referenced Nov 20, 2018
Ms2ger
approved these changes
Nov 26, 2018
|
@Ms2ger This branch has a commit prefixed with |
|
Sure; I overlooked the commit here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file
FileAPI/url/url-with-tags.window.jsis not currently presentin the repository nor was it present when the reference was introduced
[1]. Remove it to avoid triggering spurious request failures during test
execution.
[1] 9d8a185