Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when errorFields don't match options #14246

Merged
merged 2 commits into from
Mar 4, 2019
Merged

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres
Copy link
Contributor Author

Reported @danielramn for spam

aarongable pushed a commit to chromium/chromium that referenced this pull request Dec 5, 2018
Related spec change:
  w3c/payment-request#807

Test:
  web-platform-tests/wpt#14246

Bug: 909577
Change-Id: Idb4caa2ad08193decaf1d4b0b0435e958176929b
Reviewed-on: https://chromium-review.googlesource.com/c/1359932
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#613788}
@marcoscaceres
Copy link
Contributor Author

@rsolomakhin could you please check this one too?

Copy link
Contributor

@rsolomakhin rsolomakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@marcoscaceres marcoscaceres reopened this Feb 14, 2019
@marcoscaceres marcoscaceres merged commit 4dbc98b into master Mar 4, 2019
@marcoscaceres marcoscaceres deleted the errorfields_warn branch March 4, 2019 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants