Revert "Enforce active lifetime of XRFrame objects" #14336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ff451c7bfc7010d9bea16d7b7036be389afa1db5. Reason for revert: Obvious culprit for WebXrVrBrowserTestStandard.TestPresentationPoses failures on the GPU FYI waterfall Windows builders. Original change's description: > Enforce active lifetime of XRFrame objects > > Deactivates XRFrame objects once the relevant callback returns, which > causes future calls to the object methods to throw an exception. > > Bug: 906842 > Change-Id: I192453f9f23b1b4d9a404daca352ab80a5393753 > Reviewed-on: https://chromium-review.googlesource.com/c/1343065 > Commit-Queue: Brandon Jones <bajones@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612887} TBR=bajones@chromium.org,klausw@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 906842 Change-Id: I3ad87a50a85dffb6eb3b20a6230eee607bf46f0e
wpt-pr-bot
approved these changes
Dec 3, 2018
|
Close this PR because the Chromium CL has been abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ff451c7bfc7010d9bea16d7b7036be389afa1db5.
Reason for revert: Obvious culprit for
WebXrVrBrowserTestStandard.TestPresentationPoses failures on the
GPU FYI waterfall Windows builders.
Original change's description:
TBR=bajones@chromium.org,klausw@chromium.org
Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 906842
Change-Id: I3ad87a50a85dffb6eb3b20a6230eee607bf46f0e
Reviewed-on: https://chromium-review.googlesource.com/1356966
WPT-Export-Revision: 8707d089152dccede571126ea1beebcfba322c43