Trusted Types: URLs should be USVString, not DOMString. #14377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 5, 2018
This patch adjusts `ScriptURLString` to be a union including `USVString`, not `DOMString`. The advice in [WebIDL][1] isn't exactly clear, but it boils down to @domenic's notes in [whatwg/webidl#84][2] and [w3ctag/design-principles#93][3]. Long story short, URLs are `USVString`. This patch adjusts our implementation to match. [1]: https://heycam.github.io/webidl/#idl-USVString [2]: whatwg/webidl#84 (comment) [3]: w3ctag/design-principles#93 (comment) Change-Id: I9bf1240b421287d7d9c291b13d887ca981a66231
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1363178
branch
from
dc55d92 to
7d92dbd
Compare
mingyc
added a commit
to WICG/pending-beacon
that referenced
this pull request
Jun 29, 2022
The proposal of `setData()` is to take the data of the same types as `sendBeacon()`'s, which takes an USVString` instead of `DOMString`. The `url` should be USVString as described in [this issue][1]. [1]: web-platform-tests/wpt#14377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adjusts
ScriptURLStringto be a union includingUSVString,not
DOMString. The advice in WebIDL isn't exactly clear, but itboils down to @domenic's notes in heycam/webidl#84 and
w3ctag/design-principles#93.
Long story short, URLs are
USVString. This patch adjusts ourimplementation to match.
Change-Id: I9bf1240b421287d7d9c291b13d887ca981a66231
Reviewed-on: https://chromium-review.googlesource.com/1363178
WPT-Export-Revision: 98c00dc650d15c101d6fa9619f864f4e04b0ddbd