[eme] Check if HDCP policy is supported #14384
Conversation
In [1] there is a proposal to add the ability to know before fetching content if HDCP (and what version) can be enforced. This adds a test to check if it is supported. [1] https://github.com/WICG/hdcp-detection/blob/master/explainer.md
| // don't bother checking the result returned as it may or | ||
| // may not be supported. This simply verifies that | ||
| // getStatusForPolicy() exists and doesn't blow up. | ||
| return mediaKeys.getStatusForPolicy({minHdcpVersion: hdcpPolicy}); |
There was a problem hiding this comment.
This might return a rejected promise, e.g. for clear key. Will this cause the test to fail? For the context, see WICG/hdcp-detection#2
There was a problem hiding this comment.
The test will fail, but if you look at the results you will see the failure due to error NotSupportedException. I think this is better for developers as they will see that it is not supported on the platform (by clear key, for example) and recognize they need to handle the failure. This is similar to the persistent-session tests (that are optional, but it is useful to know that persistent sessions aren't supported).
| promise_test( | ||
| () => checkHdcpPolicy(''), | ||
| testnamePrefix(qualifier, config.keysystem) + | ||
| ' support for empty HDCP policy.'); |
| @@ -0,0 +1,26 @@ | |||
| function runTest(config, qualifier) | |||
| { | |||
| function checkHdcpPolicy(hdcpPolicy) | |||
There was a problem hiding this comment.
This should be something like checkStatusForMinHdcpVersionPolicy(hdcpVersion)
| // don't bother checking the result returned as it may or | ||
| // may not be supported. This simply verifies that | ||
| // getStatusForPolicy() exists and doesn't blow up. | ||
| return mediaKeys.getStatusForPolicy({minHdcpVersion: hdcpPolicy}); |
There was a problem hiding this comment.
see above. s/hdcpPolicy/hdcpVersion
| <html> | ||
| <head> | ||
| <meta charset=utf-8> | ||
| <title>Encrypted Media Extensions: Check HDCP policy with Clear Key</title> |
There was a problem hiding this comment.
Here and below and in the file names, to be accurate, this should be something like "Check status for minHdcpVersion policy"
There was a problem hiding this comment.
Done. Kept the files names simple with check-hdcp-version.
In [1] there is a proposal to add the ability to know before fetching content
if HDCP (and what version) can be enforced. This adds a test to check if it
is supported.
[1] https://github.com/WICG/hdcp-detection/blob/master/explainer.md