Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Picture-in-Picture] Don't require user gesture if capturing user media #14390

Closed
wants to merge 1 commit into from
Closed

[Picture-in-Picture] Don't require user gesture if capturing user media #14390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion picture-in-picture/mediastream.html → picture-in-picture/mediastream.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,25 @@
assert_not_equals(pipWindow.width, 0);
assert_not_equals(pipWindow.height, 0);
});
}, 'request Picture-in-Picture resolves on user click with Picture-in-Picture window');
}, 'request Picture-in-Picture with canvas resolves on user click with Picture-in-Picture window');

promise_test(async t => {
const video = document.createElement('video');
video.muted = true;
video.srcObject = await navigator.mediaDevices.getUserMedia({ video: true });
await video.play();
return requestPictureInPictureWithTrustedClick(video)
.then(pipWindow => {
assert_not_equals(pipWindow.width, 0);
assert_not_equals(pipWindow.height, 0);
});
}, 'request Picture-in-Picture with getUserMedia resolves on user click with Picture-in-Picture window');

promise_test(async t => {
const video = document.createElement('video');
video.muted = true;
video.srcObject = await navigator.mediaDevices.getUserMedia({ video: true });
await video.play();
return video.requestPictureInPicture();
}, 'request Picture-in-Picture does not require user gesture if document is capturing user media');
</script>