Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests that check SDP after transceiver stop #14423

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Add some tests that check SDP after transceiver stop #14423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 82 additions & 0 deletions webrtc/RTCRtpTransceiver-stop.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
<!doctype html>
<meta charset=utf-8>
<title>RTCRtpTransceiver.prototype.stop</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="RTCPeerConnection-helper.js"></script>
<script>
// FIXME: Add a test adding a transceiver, stopping it and trying to create an empty offer.

promise_test(async (t)=> {
const pc1 = new RTCPeerConnection();
youennf marked this conversation as resolved.
Show resolved Hide resolved
youennf marked this conversation as resolved.
Show resolved Hide resolved
t.add_cleanup(() => pc1.close());

pc1.addTransceiver("audio", { direction: "sendonly" });
pc1.addTransceiver("video");
pc1.getTransceivers()[0].stop();

const offer = await pc1.createOffer();

assert_false(offer.sdp.includes("m=audio"), "offer should not contain an audio m-section");
assert_true(offer.sdp.includes("m=video"), "offer should contain a video m-section");
}, "A transceiver added and stopped before the initial offer generation should not trigger an offer m-section generation");

promise_test(async (t)=> {
const pc1 = new RTCPeerConnection();
const pc2 = new RTCPeerConnection();
t.add_cleanup(() => pc1.close());
t.add_cleanup(() => pc2.close());

pc1.addTransceiver("audio");

await exchangeOfferAnswer(pc1, pc2);

pc1.addTransceiver("video");

pc1.getTransceivers()[0].stop();
pc1.getTransceivers()[1].stop();

const offer = await pc1.createOffer();

assert_true(offer.sdp.includes("m=audio"), "offer should contain an audio m-section");
assert_true(offer.sdp.includes("m=audio 0"), "The audio m-section should be rejected");

assert_false(offer.sdp.includes("m=video"), "offer should not contain a video m-section");
}, "During renegotiation, adding and stopping a transceiver should not trigger a renegotiated offer m-section generation");

promise_test(async (t)=> {
const pc1 = new RTCPeerConnection();
const pc2 = new RTCPeerConnection();
t.add_cleanup(() => pc1.close());
t.add_cleanup(() => pc2.close());

pc1.addTransceiver("audio");

await exchangeOfferAnswer(pc1, pc2);

pc1.getTransceivers()[0].direction = "sendonly";
pc1.getTransceivers()[0].stop();

const offer = await pc1.createOffer();

assert_true(offer.sdp.includes("a=sendonly"), "The audio m-section should be sendonly");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong.

}, "A stopped sendonly transceiver should generate an inactive m-section in the offer");

promise_test(async (t)=> {
const pc1 = new RTCPeerConnection();
const pc2 = new RTCPeerConnection();
t.add_cleanup(() => pc1.close());
t.add_cleanup(() => pc2.close());

pc1.addTransceiver("audio");

await exchangeOfferAnswer(pc1, pc2);

pc1.getTransceivers()[0].direction = "inactive";
pc1.getTransceivers()[0].stop();

const offer = await pc1.createOffer();

assert_true(offer.sdp.includes("a=inactive"), "The audio m-section should be inactive");
}, "A stopped inactive transceiver should generate an inactive m-section in the offer");
</script>