Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress flake8 error about bare except. #14450

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Suppress flake8 error about bare except. #14450

merged 1 commit into from
Dec 11, 2018

Conversation

jdm
Copy link
Contributor

@jdm jdm commented Dec 11, 2018

Fixes #14448.

@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Dec 11, 2018
@jdm
Copy link
Contributor Author

jdm commented Dec 11, 2018

cc @Hexcles

@foolip
Copy link
Member

foolip commented Dec 11, 2018

Can't merge because of what looks like an unrelated failure in https://travis-ci.org/web-platform-tests/wpt/jobs/466323770. I've saved the log in https://gist.github.com/foolip/47c2c804ed6488aa319cfb1ebad670cc.

Seems like the failure has something to do with the Firefox path, and I do see mozdownload in the log, although not failures. Guessing that this might be the same root cause as #13274 and restarting.

@foolip
Copy link
Member

foolip commented Dec 11, 2018

https://travis-ci.org/web-platform-tests/wpt/jobs/466323770 still failed, this time for test_install_firefox and clearly because of network issues:
https://gist.github.com/foolip/feeec92015faf8134368f80ffc49a570#file-log-txt-L1511

I'll just admin merge, because this is blocking other stuff too.

@foolip foolip merged commit 9f42aa0 into master Dec 11, 2018
@foolip foolip deleted the jdm-patch-3 branch December 11, 2018 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants