Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted Types: Implement Origin Trial (TrustedDOMTypes) #15040

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 24, 2019

This also removes TrustedDOMTypes from workers since we had
difficulty bringing it into the origin trial. They will be re-added
later.

Bug: 739170
Change-Id: Iec6206f1c3c8121f30d7fbdb13054e4e30255fd2
Reviewed-on: https://chromium-review.googlesource.com/c/1411775
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625666}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1411775 branch 2 times, most recently from 0d89277 to f848a31 Compare January 24, 2019 16:31
@foolip
Copy link
Member

foolip commented Jan 25, 2019

Hmm, Taskcluster never started on this PR. I haven't seen that before, will make note of it on #14210.

@foolip
Copy link
Member

foolip commented Jan 25, 2019

I'm going to rebase the branch to trigger new checks. Here's what it looked like:
image

This also removes TrustedDOMTypes from workers since we had
difficulty bringing it into the origin trial. They will be re-added
later.

Bug: 739170
Change-Id: Iec6206f1c3c8121f30d7fbdb13054e4e30255fd2
Reviewed-on: https://chromium-review.googlesource.com/c/1411775
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625666}
@foolip foolip force-pushed the chromium-export-cl-1411775 branch from f848a31 to 5fdcf29 Compare January 25, 2019 12:13
@foolip
Copy link
Member

foolip commented Jan 25, 2019

That worked, all CI are happy!

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 7f3dccb into master Jan 25, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1411775 branch January 25, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants