Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mozilla csp tests #1634

Merged
merged 1 commit into from
Feb 23, 2015
Merged

Mozilla csp tests #1634

merged 1 commit into from
Feb 23, 2015

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Feb 23, 2015

This change is Reviewable

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4070

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger Ms2ger mentioned this pull request Feb 23, 2015
@mikewest
Copy link
Member

LGTM! We'll need to rationalize these with the existing tests, but it seems pretty reasonable to merge it in now. That said, there's apparently a python linting error?

Ms2ger added a commit that referenced this pull request Feb 23, 2015
Mozilla csp tests; r=mikewest
@Ms2ger Ms2ger merged commit 7b1f1c1 into master Feb 23, 2015
@Ms2ger Ms2ger deleted the mozilla_csp_tests branch February 23, 2015 11:34
@tobie tobie added the CSP label Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants