Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service workers: Simplified tests with async/await - Part 3 #16555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

service workers: Simplified tests with async/await - Part 3 #16555

wants to merge 1 commit into from

Conversation

wanghongjuan
Copy link
Contributor

[NewObject] Promise unregister();
unregister() method must run these steps:

  1. Let promise be a promise.
    ...
  2. Return promise.

@wanghongjuan
Copy link
Contributor Author

It's a common issue regarding to the usage of t. add_cleanup() and unregister(), which will produce a big PR that is not easy to review, this is the third pr after #13103 and #16322 .

@Hexcles Hexcles closed this Apr 26, 2019
@Hexcles Hexcles reopened this Apr 26, 2019
@wanghongjuan
service workers: Simplified tests with async/await - Part 3
c93aa52 
- Fix a couple of tests with function t.add_cleanup() as it supports promise, see detail in web-platform-tests#8748.
- The usage of unregister() method in some tests is not rigorous.  As [spec]\(https://w3c.github.io/ServiceWorker/#dom-serviceworkerregistration-unregister):
>>   [NewObject] Promise<boolean> unregister();
  unregister() method must run these steps:
>> 1. Let promise be a promise.
...
>> 4. Return promise.
@wanghongjuan wanghongjuan force-pushed the fix-cleanup-unregister-3 branch from c67ae49 to c93aa52 Compare April 29, 2019 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asutherland asutherland Awaiting requested review from asutherland

@mfalken mfalken Awaiting requested review from mfalken

@mkruisselbrink mkruisselbrink Awaiting requested review from mkruisselbrink

@wanderview wanderview Awaiting requested review from wanderview

At least 1 approving review is required to merge this pull request.

Assignees

@wanderview wanderview

Labels
service-workers wg-sw
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wanghongjuan @wanderview @Hexcles @wpt-pr-bot