Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add structured clone tests for errors #17095

Merged
merged 3 commits into from
Jul 10, 2019
Merged

Add structured clone tests for errors #17095

merged 3 commits into from
Jul 10, 2019

Conversation

yutakahirano
Copy link
Contributor

@yutakahirano yutakahirano commented May 30, 2019 •
edited
Loading

@yutakahirano yutakahirano marked this pull request as ready for review May 30, 2019 06:56
This was referenced May 30, 2019
Merged
Merged
domenic
domenic approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with additional test suggestions. I can work on an optional test for stack.

html/infrastructure/safe-passing-of-structured-data/structuredclone_0.html Show resolved Hide resolved
domenic added a commit that referenced this pull request Jun 4, 2019
@domenic
Add optional test for cloning of error stacks
930edf9 
Supplements #17095.
Follows whatwg/html#4665 and whatwg/webidl#732.
@domenic domenic mentioned this pull request Jun 4, 2019
Merged
@domenic
Copy link
Member

domenic commented Jul 2, 2019

Added another test, PTAL @yutakahirano

domenic pushed a commit to whatwg/html that referenced this pull request Jul 3, 2019
@yutakahirano @domenic
Define serialization and deserialization steps for errors
af9f087 
Define serialization and deserialization steps for all built-in
NativeError types from the JavaScript specification. This change doesn't
cover DOMExceptions, which are covered by
whatwg/webidl#732.

Fixes #4268.

Tests:
* web-platform-tests/wpt#17095
* web-platform-tests/wpt#17159
domenic pushed a commit to whatwg/webidl that referenced this pull request Jul 3, 2019
@yutakahirano @domenic
Make DOMException serializable
f23ef42 
Fixes #729. See also whatwg/html#4268.

Tests:
* web-platform-tests/wpt#17095
* web-platform-tests/wpt#17159
@domenic
Copy link
Member

domenic commented Jul 3, 2019

Going to close and reopen to try to fix the taskcluster failure.

@domenic domenic closed this Jul 3, 2019
@domenic domenic reopened this Jul 3, 2019
yutakahirano
yutakahirano commented Jul 9, 2019
View reviewed changes
html/infrastructure/safe-passing-of-structured-data/structuredclone_0.html
assert_equals(e.data.foo, undefined, "Checking custom property");
});
t.step(function() {
const error = frames[0].URIError("some message");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check Object.getPrototypeof(error), error.constructor and error.name?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn't be necessary in this setup step, I think? But I will add them anyway, and we can always revert.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

annevk pushed a commit that referenced this pull request Jul 9, 2019
@domenic @annevk
Add optional test for cloning of error stacks
77560c4 
Supplements #17095.
Follows whatwg/html#4665 and whatwg/webidl#732.
domenic added a commit that referenced this pull request Jul 9, 2019
@domenic
Add optional test for cloning of error stacks
1da6bed 
Supplements #17095.
Follows whatwg/html#4665 and whatwg/webidl#732.
@foolip
Copy link
Member

foolip commented Jul 10, 2019

Rebasing this should fix the Taskcluster failure, while just running again doesn't because the Taskcluster config from the PR branch is used and not what is on master.

But admin merging instead since the failure is a known and fixed one.

@foolip foolip merged commit 84af6c8 into web-platform-tests:master Jul 10, 2019
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 24, 2019
@domenic @jgraham
Bug 1556663 [wpt PR 17159] - Add optional test for cloning of error s…
4aee476 
…tacks, a=testonly

Automatic update from web-platform-tests
Add optional test for cloning of error stacks

Supplements web-platform-tests/wpt#17095.
Follows whatwg/html#4665 and whatwg/webidl#732.
--

wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da
wpt-pr: 17159


--HG--
rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/echo-iframe.html => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/resources/echo-iframe.html
rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/echo-worker.js => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/resources/echo-worker.js
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Jul 25, 2019
@domenic @jgraham
Bug 1556663 [wpt PR 17159] - Add optional test for cloning of error s…
dd555c1 
…tacks, a=testonly

Automatic update from web-platform-tests
Add optional test for cloning of error stacks

Supplements web-platform-tests/wpt#17095.
Follows whatwg/html#4665 and whatwg/webidl#732.
--

wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da
wpt-pr: 17159
natechapin pushed a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
@domenic @natechapin
Add optional test for cloning of error stacks
a77cab6 
Supplements web-platform-tests#17095.
Follows whatwg/html#4665 and whatwg/webidl#732.
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1556663 [wpt PR 17159] - Add optional test for cloning of error s…
d5e323a 
…tacks, a=testonly

Automatic update from web-platform-tests
Add optional test for cloning of error stacks

Supplements web-platform-tests/wpt#17095.
Follows whatwg/html#4665 and whatwg/webidl#732.
--

wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da
wpt-pr: 17159

UltraBlame original commit: d0647ab7df5d71c33b5c35b8b4ce69940975639e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
@marco-c
Bug 1556663 [wpt PR 17159] - Add optional test for cloning of error s…
d7218dd 
…tacks, a=testonly

Automatic update from web-platform-tests
Add optional test for cloning of error stacks

Supplements web-platform-tests/wpt#17095.
Follows whatwg/html#4665 and whatwg/webidl#732.
--

wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da
wpt-pr: 17159

UltraBlame original commit: d0647ab7df5d71c33b5c35b8b4ce69940975639e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1556663 [wpt PR 17159] - Add optional test for cloning of error s…
a02ee55 
…tacks, a=testonly

Automatic update from web-platform-tests
Add optional test for cloning of error stacks

Supplements web-platform-tests/wpt#17095.
Follows whatwg/html#4665 and whatwg/webidl#732.
--

wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da
wpt-pr: 17159

UltraBlame original commit: d0647ab7df5d71c33b5c35b8b4ce69940975639e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@annevk annevk Awaiting requested review from annevk

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zcorpan zcorpan Awaiting requested review from zcorpan

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@jgraham jgraham

Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yutakahirano @domenic @foolip @TimothyGu @jgraham @wpt-pr-bot