Ignore the stacktrace when checking errors #17213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @foolip - how do I fix the test failure "tools.wpt.run.WptrunError: Unable to locate safaridriver binary"? |
|
@danyao, the problem was that Safari TP is no longer available for High Sierra, installed from Homebrew/homebrew-cask-versions#7450. However, #17187 was just merged pinning to an older release of Safari TP for unrelated reasons, so just rebasing the branch should fix it. I'm attempting to upgrade the macOS version in #17219. |
danyao
force-pushed
the
danyao-allowpaymentrequest-tests
branch
from
c02dd9b
to
e4bfc47
Compare
rsolomakhin
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a test regression introduced by #12713.
These tests use
assert_array_equalsone.data.details. Pull/12713 changed the expected length ofe.data.detailsby also including the error stacktrace as a 4th element. This pull request changes the tests to only check for the first 3 elements.