MathML: Add tests for children not participating to their parent layout #18293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds new tests to verify that children with "display: none", "position: absolute" or "position: fixed" don't affect preferred width calculation or layout of their parents. - mathml/support/mathml-fragments.js: Add function to append a non empty child (optionally making the element invalid) and use that function for forceNonEmptyElement. - mathml/support/layout-comparison.js: Introduce new helpers function to extract the children participating to their parent layout. Modify compareLayout so that it browser that list of children instead and allow comparison in horizontal+LTR mode.
|
There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
|
Note: This (unsurprisingly) causes assertion failure in Igalia's Chromium build. |
rwlbuis
approved these changes
Aug 6, 2019
Right, I had checked and Chromium has two different functions for out-of-flow and float: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/api/line_layout_item.h?q=OutOfFlowPositioned&dr=CSs&l=140 I'm not sure yet what mathml core should say for floats but will add a TODO |
|
I forgot to say in the commit, but this is related to https://github.com/mathml-refresh/mathml/issues/16 |
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
…ut (web-platform-tests#18293) * MathML: Add tests for children not participating to their parent layout This commit adds new tests to verify that children with "display: none", "position: absolute" or "position: fixed" don't affect preferred width calculation or layout of their parents. - mathml/support/mathml-fragments.js: Add function to append a non empty child (optionally making the element invalid) and use that function for forceNonEmptyElement. - mathml/support/layout-comparison.js: Introduce new helpers function to extract the children participating to their parent layout. Modify compareLayout so that it browser that list of children instead and allow comparison in horizontal+LTR mode. * Add feature detection otherwise these tests pass when MathML is disabled. * Add TODO for floats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds new tests to verify that children with "display: none",
"position: absolute" or "position: fixed" don't affect preferred width
calculation or layout of their parents.
mathml/support/mathml-fragments.js: Add function to append a non empty
child (optionally making the element invalid) and use that function for
forceNonEmptyElement.
mathml/support/layout-comparison.js: Introduce new helpers function to
extract the children participating to their parent layout. Modify
compareLayout so that it browser that list of children instead and allow
comparison in horizontal+LTR mode.