Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the results jobs when idlharness.js changes #18500

Merged
merged 4 commits into from
Sep 26, 2019
Merged

Run the results jobs when idlharness.js changes #18500

merged 4 commits into from
Sep 26, 2019

Conversation

lukebjerring
Copy link
Contributor

Includes #18382 temporarily to fully test the behaviour.

@lukebjerring lukebjerring mentioned this pull request Aug 16, 2019
Merged
jgraham
jgraham approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@jgraham jgraham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to removing earlier commit

@ghost
Copy link

ghost commented Aug 16, 2019

Submitting the task to Taskcluster failed. Details

InterpreterError at template.tasks[1].payload.command[3]: object has no property job_name

1 similar comment
@ghost
Copy link

ghost commented Aug 16, 2019

Submitting the task to Taskcluster failed. Details

InterpreterError at template.tasks[1].payload.command[3]: object has no property job_name

@lukebjerring lukebjerring changed the title Run the stability job when idlharness.js changes Run the results jobs when idlharness.js changes Aug 16, 2019
@lukebjerring
Copy link
Contributor Author

@jgraham - I've totally changed this PR, as per discussion, it makes sense to distinguish the single run job from stability for the idlharness.js case.

PTAL

@lukebjerring lukebjerring reopened this Aug 16, 2019
@ghost
Copy link

ghost commented Aug 16, 2019

Submitting the task to Taskcluster failed. Details

InterpreterError at template.tasks[1].payload.command[3]: object has no property job_name

@lukebjerring lukebjerring mentioned this pull request Sep 2, 2019
Closed
foolip
foolip approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me, but I'd like to hear if @jgraham has more feedback. When I was setting up Azure Pipelines I think I suggested introducing an affected_tests job, but ended up making the jobs unconditional instead.

I wonder if we should change Azure Pipelines to use this new job as well, or make unconditional on Taskcluster too? (Need not block this change.)

@foolip foolip mentioned this pull request Sep 3, 2019
Merged
@gsnedders
Copy link
Member

Does it really not timeout running the stability job for idlharness.js? Huh.

@lukebjerring
Copy link
Contributor Author

No, you're right, it does time out, which is why this change distinguishes single run from stability for including idlharness.js.

@gsnedders
Copy link
Member

Gah. I can't read. 🙂

This looks reasonable to me too.

@lukebjerring
Copy link
Contributor Author

Taskcluster failure is #19297

@lukebjerring lukebjerring merged commit 120c6c0 into master Sep 26, 2019
@lukebjerring lukebjerring deleted the idlharness-stability branch September 26, 2019 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

@gsnedders gsnedders Awaiting requested review from gsnedders

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

@jgraham jgraham Awaiting requested review from jgraham

Assignees

@jgraham jgraham

Labels
ci idlharness.js infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lukebjerring @gsnedders @jgraham @foolip @wpt-pr-bot @moz-wptsync-bot