shadow dom : add text-decoration test for overline #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/173 This is an external review system which you may optionally use for the code review of your pull request. |
| <head> | ||
| <meta charset="utf-8" > | ||
| <title>Text Decoration Over Line Test</title> | ||
| <link rel="reference" href="text-decoration-overline-ref.html"> |
There was a problem hiding this comment.
rel="reference" should be rel="match".
|
What do you think about merging tests about text-decoration into a one reftest? At least, we can share a reference file (-ref.html) for all tests. |
|
I think test should be divided by one object or function. So, merging test is good proposal. |
gsnedders
added a commit
that referenced
this pull request
May 13, 2019
ea389ca278 chore(package): bump version number to 20.0.1 518e5cc12b chore(CHANGELOG): regenerate aa3588b457 chore(dist): update 7ceaf0ee5b refactor(lib/webidl2): enum as a module (#318) 27b0eb31d3 fix(lib/webidl2): emit error message correctly (#317) bcb8c32c69 docs(lib/writer): fix extendedAttribute example 1ddd771ed8 docs(lib/writer): document generic() (#315) 86029c5866 chore(package): bump version number to 20.0.0 f195b986b8 chore(CHANGELOG): regenerate 7423f5d8f7 chore(dist): update 996d4f7e71 feat(lib/writer): introduce generic() hook (#314) 87b07ec705 refactor(lib/webidl2): modularize Default (#312) be140dad86 refactor(lib/webidl2): modularize Token and list() (#311) 464d3a1e2b refactor(lib/webidl2): modularize Includes (#310) 6b3b7c54f5 chore(package): bump version number to 19.0.1 c68baccbb2 chore(CHANGELOG): regenerate 97851631ab chore(dist): update 1cc6b3e257 fix(lib/writer): call ts.trivia with actual string (#309) e84ba4fd34 chore(CHANGELOG): regenerate 37f87e6393 chore(package): bump version number to 19.0.0 6486380999 update dist 6340c3e1e4 fix(lib/webidl2): restore error fields (#308) c6a7c97358 fix(lib/webidl2): rename float as decimal (#307) 048e3d748e BREAKING CHANGE: remove all trivia fields (#306) f37e39e928 BREAKING CHANGE: remove baseName and escaped* fields (#305) b0c5a9e5e6 BREAKING CHANGE: remove token fields (#304) e1aa18822f BREAKING CHANGE: remove trivia from boolean fields (#303) 112862924c refactor: merge error functions (#299) 1926437649 fix(checker): add an empty line between messages (#298) 3de7e3066a chore(package): bump version number to 18.0.1 a3637e9c20 update build 09c4e4f725 chore(package): bump version number to 18.0.0 df4c73deef fix(lib/validator): validate when overloads are all from mixins (#296) a8e81d479e refactor: use module for checker (#295) 679395293f fix(checker): use webpack build result (#294) abd41222d5 refactor: use ES module syntax and bundle by webpack (#293) aa75ae538c feat: add validation feature to the checker page (#292) b7e7b1ba99 feat: a validator for IDL (#262) 852194f5ee refactor: remove remaining JSON idlTypes (#291) b8590cd281 refactor: use Type for primitive types (#290) 44987f3bf5 refactor: generic type as a class (#289) c86dac1295 refactor: union type as a class (#288) 64f0fa50d7 refactor: argument as a class (#287) 209c1d4cf4 fix(lib/webidl2): disallow empty generic type (#286) 927328d5c7 fix(lib/webidl2): disallow null on constants (#284) 45287bf978 refactor: use list() in identifiers()/enums (#285) 2d555baf51 refactor: extended attributes as a class (#283) 11afb8e7ea refactor: extended attribute as a class (#282) 7d1562c406 refactor: default value as a class (#281) 812a292252 BREAKING CHANGE: constant as a class (#280) 44b68f8afc refactor(lib/writer): use tokens object in container() (#273) a9bb14d43e add a test case (#277) 7c07ca4eb5 refactor: attribute as a class (#276) a25f052736 refactor: operation as a class (#275) dba7a4b8b7 test(lib/webidl2): nullable constant with typedef identifiers (#279) 903c374ebb refactor: callback function as a class (#278) f396b5182d refactor: iterable as a class (#274) 810d2db4cf refactor: containers as classes (#272) ce9787caab refactor: namespace as a class (#271) 56a590d327 refactor: dictionary as a class (#270) 5e51ccec85 refactor: field as a class (#268) 9643425b8e refactor(lib/webidl2): move toJSON to Definition (#269) c13e3aa65f refactor: enum as a class (#267) ae4a1b4fd8 refactor: typedef as a class (#266) 81edfc0774 refactor: includes as a class (#265) f9c0d44f49 chore: add .gitattributes (#264) 51618dced6 style: apply no-trailing-spaces (#263) d9c160f4ba chore(package): bump version number to 17.0.2 1a2147bb20 fix(lib/webidl2): apply a preceding hyphen for identifiers (#261) c27f3c3e94 fix(checker): avoid using innerText (#260) 4b0443568c fix(lib/webidl2): restore enum value string form in error (#258) 805e2b2ea2 docs: lowercase the example namespace "Console" (#257) 16d5a92b2d chore(CHANGELOG): regenerate 3bb235ca95 chore(package): bump version number to 17.0.1 1aa1258028 fix: unescape includes/idlTypes/inheritances (#253) e57f46632b fix(lib/webidl2): prevent any in a union type (#254) 8cbec8b4d0 Revert "fix(lib/webidl2): prevent any in a union type" 73c15634ac fix(lib/webidl2): prevent any in a union type c393451a43 feat(lib/webidl): subclass standard error (#247) 6e2a83bfee chore(CHANGELOG): regenerate 3f8ac3f23b 17.0.0 9e2c43da44 BREAKING CHANGE: remove .extAttrs from arguments (#248) ec05bc243b 16.1.0 4ae64a8766 Add unit tests for writer template functions (#245) dd89780e22 feat(lib/webidl2): better error messages (#244) edaf314b6a Add docs for template feature (#243) df4484597e Revert "add test for writer template feature" 19f5e6e8f8 Revert "upgrade eslint" 7e886e9f26 add test for writer template feature 1313c80c16 upgrade eslint 1014b33145 feat(lib/writer): write() with optional templates (#241) 5d5a645936 chore(package): bump version number to 16.0.0 3c538be29f BREAKING CHANGE: merge modifier fields (#240) 7350bb1227 refactor(lib/writer): use container() (#239) b215543038 refactor(lib/writer): use token() (#238) 0a0bfa9ee9 refactor(lib/writer): reduce conditional constructs (#237) 40a048b800 chore: remove jscov (#236) 018b24f7fc chore(package): update eslint (#235) d38c4ed618 eslint: prevent eval() (#234) 8ff7a963cf chore(package-locK): regenerate 731f5edb5a chore(CHANGELOG): regenerated d759b8c968 chore(package): update version + deps 568e1d5db6 docs(README): enum value's type is now enum-value (#233) f3462f9501 BREAKING CHANGE: enum values should be of type enum-value (#232) 46b250286d fix: escape top identifiers (#229) 91bba911e5 fix(lib/webidl): disallow multiple special keywords (#224) b2a9f6c901 BREAKING CHANGE: Drop support for implements statement (#106) da93c9373b refactor(lib/writer): horizontally shorter type() (#221) 2e03190e30 chore(README): operation body always has idlType (#218) 6cc3277c9d chore(package): bump version number to 14.0.1 a3e89c87d2 fix(index): import writer from index (#219) 1582972c21 chore(CHANGELOG): regenerate 402e4e3514 chore(package): bump version number to 14.0.0 698b8e991d Document changes for idlType and extAttrs (#217) 7328816495 Document trivia for root type declarations/members (#214) b3fd89040d BREAKING CHANGE: remove support for legacyiterable (#216) cce0d6d484 Document trivia for iterable-likes (#213) b5b4d90a12 Document trivia for interfaces/mixins/namespaces (#212) 69a0f2b5ac Document generic array, escapedName and removal of sequence (#211) 7d08a0c8af BREAKING CHANGE: support full whitespace conservation (#185) bbe95578bd trivia for implements/includes (#209) 9df331ce7d Add trivia for enums and typedefs (#207) 2559b95c75 Add trivia for callbacks (#206) 4cbd4143ba Add trivia for partial types (#205) fc147026f7 trivia for dictionaries (#204) be9126fa7b Add trivia for mixins and namespaces (#203) b02aa3366a Use eslint minimally (#202) 74cd53340d Add trivia for extended attributes (#201) 7524981417 Add trivia for extended attribute identifiers (#200) 3d682826e2 Add trivia for const member type (#199) 25d5919278 trivia for arguments (#198) b17417ca83 trivia for operation (#197) 6e12a109d1 trivia for inheritance (#195) 79d791a389 Add trivia for iterable declarations (#194) 0cb3e7cba4 Add trivia for modifiers (#193) ecebf30070 Add trivia for idlTypes (#192) 32f11bc730 BREAKING CHANGE: remove nullable field from const type (#189) f4292a7a21 Generics always as an array (#188) 1ea9f9c91a fix: prevent empty iterable declaration (#187) d36f7e4b7e Add trivia field for interfaces/mixins (#186) git-subtree-dir: resources/webidl2 git-subtree-split: 306cf6479f909a38297c4982e79171958669fe55
Hexcles
added a commit
that referenced
this pull request
Dec 1, 2020
b1b07a3096 manual changelog entry 742f4705fb Preparing release 0.13.1 39a6d69031 tox: release: use python3 a5130ac87a Merge pull request #232 from kinow/patch-1 9890e90f6d Merge pull request #236 from hoefling/master d5b871dee3 fixed wrong refs by class name in PluginManager docstring 0e57e28df2 updated broken links due to acc name change ca1ddebd3b added cross-referencing in docstrings, some formatting improvements 7f5213ea9a fixed broken links, added missing refs in apidoc, using intersphinx where possible fe5a72bc92 Merge pull request #234 from asottile/release-0.13.0 93a6b83769 Preparing release 0.13.0 5b7aba1a83 Fix simple typo: specfication -> specification (#233) c8872e2b23 Fix simple typo: specfication -> specification 4d546fe479 Add the output of the example code e40a877135 Merge pull request #226 from bluetech/simplify-tracing 4497278ec2 Avoid an intermediary variable 14e9d85ca5 Merge pull request #229 from blueyed/tox-py 12133da6cb test_pluginmanager: use pluggy.manager.metadata 2ef0090917 tox.ini: make "tox -e py37" etc work 8900b4c09e Do the string joining already inside _format_message() 1be7c25235 Improve name tag2proc -> tags2proc f0535d2683 Reduce scope of except to avoid masking exceptions 1f8fdd861c Remove unhelpful _HookRelay._trace indirection a05bdd56e1 Mark a few things on TagTracer private 92e72be06e Remove TagTracerSub.setmyprocessor 69c3255f7e Inline _TracedHookExecution a1c6c3526c Merge pull request #224 from bluetech/fixes1 95dd65f538 Fix call_historic() example in index.rst 0194e630c6 Remove broken test 92c31e159b Don't confusingly reuse a variable name inside varnames() b2ffeb9962 Fix error case return type of varnames() 8aa5592b53 Replace importlib_metadata with importlib.metadata on Python 3.8+ (#223) 1bf30d695d Update tests matrix to reflect recent changes in pytest 763b661fc1 Workaround pytest-dev/pytest#5523 c66077d8c0 Replace importlib_metadata with importlib.metadata on Python 3.8+ 57b2a6dc15 Merge pull request #216 from asottile/release-0.12.0 a878c473a6 Preparing release 0.12.0 69deb13c16 importlib-metadata again (#215) 94ab205d21 Require a newer version of importlib-metadata which supports eggs b0f3b6d616 Revert "Merge pull request #206 from asottile/revert-199-importlib_metadata_v2" 7f8f8eb442 Merge pull request #214 from nicoddemus/revert-signature 4e728aa40a Revert varnames() refactor to use inspect.Signature d4d45c9190 Fix a regression with keyword only arguments (#213) bebd02418f Fix a regression with keyword only arguments f8108d791f Convert hooks.varnames() to inspect.signature() on Python 3 (#210) 39c6247294 Add CHANGELOG for #209 2008a3d5d1 Check for funcsigs using sys.version_info 0a7fec29cf Add testing for py38 on Travis 68e56e553d Separate function for unbound method detection 62f28acac8 Use funcsigs on Python 2 6504cb358a Use --force-reinstall when installing tox 04ef19308e Update setuptools and pip before installing tox ec28f02718 Convert hooks.varnames() to inspect.signature() on Python 3 f8af26cb31 Use src-layout (#203) c86cc29a79 Update support files for new src layout b46ac5f7a3 Move pluggy -> src 8e34a1ff71 fixup release script (#207) 68c8a2e421 Merge pull request #208 from asottile/release-0.11.0 e28defcbcf fixup release script e85335cbb0 Preparing release 0.11.0 07f44342e8 Merge pull request #206 from asottile/revert-199-importlib_metadata_v2 2b06ab4d96 Add changelog 45b64240dc Revert "Switch to importlib-metadata" d7a9792412 Fix CHANGELOG for 0.10.0 (#204) 6469325373 Fix CHANGELOG for 0.10.0 895b564505 Preparing release 0.10.0 (#202) 97262e812c Preparing release 0.10.0 f4eb6b426a Add changelog for #199 (#201) f1f2e3c7bd skip installation in linting env b1d68ba0cf Add changelog for #199 8749791ccd Switch to importlib-metadata (#199) 4de9e440ee Merge pull request #200 from asottile/fix_pre_commit_config 0706fbaa70 Invoke tox directly (?) f282a42a22 Expose the ImportError / AttributeError to the caller 66b2a1308a pre-commit autoupdate + fix config e387587986 Fix test for DistFacade 491cefe688 Add a Facade to pretend to be pkg_resources 9550fc30e0 Switch to importlib-metadata 59b3cf284a Merge pull request #197 from blueyed/cov 1af417351a Merge branch 'master' into cov cbd4e3ae25 Merge pull request #198 from blueyed/cfg 29c1a969d9 doc fix: is_blocked 4223913f11 tox.ini: pytest: addopts, testpaths e654da4094 ci: Travis: dist=xenial e0ad955475 Setup coverage reporting [skip appveyor] 70cb026433 ci: Travis: cache for pre-commit 4ea971188c Merge pull request #196 from jakobkogler/doc_classname_example_fix ee26b8d628 Fix class name of plugin in example 4f98685510 Merge pull request #195 from jakobkogler/docstring_typo 52c98abcf6 Fix method name `add_hookspecs` in docstring 3ef4ff87ea Merge pull request #194 from ingwinlu/patch-1 086784741b Add eggsample setup.py 1874468e21 Fix typo 758c00dc94 Merge pull request #193 from nicoddemus/skip-tests-on-deploy 61f67e05b4 Merge pull request #192 from nicoddemus/release-0.9.0 f32dee0d40 Skip tests when deploying b6a6c721a6 Preparing release 0.9.0 3c384dd377 Merge pull request #189 from nicoddemus/early-load-4718 9a12ad43ac Merge pull request #188 from nicoddemus/pypy3 0e0f0544b4 Fix internal varnames function for PyPy3 893b546aab Ignore 'pip-wheel-metadata' dir generated by pip 1d6b381d05 Add name parameter to PluginManager.load_setuptools_entrypoints 666bb4b9a9 Add testing for pypy3 cfba99d3ad Merge pull request #184 from nicoddemus/release-0.8.1 d0471e8f4a Merge pull request #185 from tgoodlet/sidebar_again a2939c044b Add html local toc sidebar to docs 317e99212f Preparing release 0.8.1 b40bcd8af9 Merge pull request #181 from crazymerlyn/change_implprefix_warning_stacklevel 72ee32f592 Merge pull request #179 from nicoddemus/skip-deploy-without-tags 2724a58a73 Merge pull request #182 from nicoddemus/update-conda-badge 3e21bfea86 Use conda-forge badge instead of anaconda 22d4417bdf Merge pull request #180 from nicoddemus/release-0.8.0 bee289c9b8 Adjust stacklevel of implprefix warning 758fd7cc04 Preparing release 0.8.0 38988e9471 Merge pull request #177 from Sup3rGeo/feature/get-plugins-for-hook f0d6f87a2a Only generate 'deploy' jobs on Travis when a tag is present a5c17ec664 Simplify asserts in test_get_hookimpls 21dec08835 Added comment to make order importance more explicit. c85f15449c Inverted order, needed for calls. e1fcf6041e Refactored to use get_hookimpls() ca0d07136e Fixed test. 163ff505cd Moved get_hookimpl to HookCaller. 17783a5504 Updated docstring. 5e1ee9552f Fixed test. bcd551d76d Added get_hookimpl with test. 1da70c931b Merge pull request #57 from tgoodlet/encapsulate_specs c967e91814 Add trivial entry 894b5e2599 Encapsulate spec definitions with a class 3a79b527f8 Merge pull request #172 from tgoodlet/test_opt_in_args 429c5fc052 Add a test demonstrating the opt in nature of args 96e94e5fb7 Merge pull request #173 from nicoddemus/plugin-count 96543a5394 Update number of pytest plugins in the docs 6587ed0d0e Merge pull request #169 from nicoddemus/pre-commit-black 9940cf2a4a Remove extra newlines at the end of files 98ae198625 Commit black-docs 2e87aefb6e Add blacken-docs pre-commit hook 851a02d5af Add black badge to README e413c70d01 Change "check" tox env to "linting" which runs pre-commit c253ce2e74 Run pre-commit in all files a07b424929 Add dev dependencies and pre-commit configuration 962d67432d Merge pull request #167 from nicoddemus/fix-changelog bccc385b9b Merge pull request #168 from fschulze/changelog 669315c835 Add changelog in long package description and documentation. Fixes #165. 5d37d7a351 Normalize all titles and add dates in CHANGELOG e601df4325 Merge pull request #160 from nicoddemus/release-0.7.0 9b48efb3f9 Run towncrier manually and fix changelog manually 72e4c2597e Fix error when handling VersionConflict exceptions from setuptools entry points 1b09518483 Merge pull request #162 from pytest-dev/nicoddemus-patch-1 94333258b0 Merge pull request #161 from gitter-badger/gitter-badge c1f661658c Merge pull request #163 from pytest-dev/pluggy-changelog-titles 8b95e0ff36 Fix Gitter badge 53af86d380 Use "pluggy" in changelog title d044159483 Skip AppVeyor when deploying 9555f4fd56 Add Gitter badge 20685531ad Preparing release 0.7.0 b607b01532 Change release command to call git directly b22cf1c244 Change #131 and #66 changelog entries to trivial 8294801d6d Merge pull request #158 from tgoodlet/newsfragments 1ad161e801 Add newsfragments for 0.7.0 release! 887951a231 Merge pull request #157 from nicoddemus/towncrier 7161f97856 Fix URL in changelog template 0fa7d9e521 Use towncrier and a custom tox environment to prepare a release dad903c4ac Merge pull request #156 from blueyed/repr df14939f50 fixup! Add HookImpl.__repr__ f05da83967 Add HookImpl.__repr__ 76232fa360 Merge pull request #153 from tgoodlet/tests_reorg dbda5aa884 Move deprecation warnings tests to a module 8573118599 Document the manager module b093f9eec0 Move manager related tests to proper module 32a02876ab Move hookcaller test to appropriate module 4c19d8da3d Rename some test modules cab120f63e Merge pull request #144 from tgoodlet/deprecate_implprefix 77578ad572 Expect deprecation warnings throughout tests 39f2136ee8 Add deprecation test 49968c25c9 Deprepate `implprefix` arg to `PluginManager` aeb1f673f3 Merge pull request #143 from tgoodlet/deprecate_proc_arg 0faf6cb669 Document result_callback arg 6b296c23f9 Deprecate `proc` kwarg to call_historic() 88fe9b9ca3 Merge pull request #142 from tgoodlet/doc_self_arg eed63e0f09 Fix typo in RuntimeError f47d9d6f1e Aggregate hyperlinks e54fc41595 Document exception handling c5a50d6c04 Point to warehouse 645cef3587 Note that `self` is ignored in hookimpl signatures 119836b53a Merge pull request #136 from Avira/elevator-pitch a20a6670c1 Improve the output and make clearer, why we do what we do in docs. e84fdfa07a fix bug in example and some more improvements/clarfications. 653a1e9bed Implement the suggestions by @tgoodlet 115f1fca63 fix phrasing and formatting. d2baceeeaf fix class name c2286a9ce6 work in fixes, suggestions from review deb62e6950 Merge pull request #139 from nicoddemus/travis-deploy ffe2caad9f fix link to devpi docs - thanks @fschulze! 6283b3b9d2 Rework the docs intro and add another example 2b39339980 optimize vertical space 9f4f954bb2 Document how to release pluggy 8029ab004d Use setuptools_scm to automatically version the package on tags 56e6ce01ee Use travis to deploy from travis to PyPI on tags e778f7a3ca Merge pull request #138 from RonnyPfannschmidt/hook-warn-defined a400a2cb9f support adding per implementation warnings for hookspecs a58b8b0fba rework of docs after discussion fb2f96c168 Merge pull request #137 from MarSoft/patch-1 e51039deb2 make knowledge part explicit b59e917135 Fix typo in docstring 5b77f41f12 introduce line breaks 0381424c15 remove redundancy 2f6831b0b0 fix grammar 26f8a94d37 change some formulations and add some links fcdc245333 high level description of pluggy by using roles e57c82a7c6 Merge pull request #129 from nicoddemus/fix-self-docs 140d6b54a2 Add missing 'self' parameter to hookimpl in docs 366946a9b0 Merge pull request #122 from ids1024/PluginValidationError-plugin 2a2c97193e Add test for PluginValidationError.plugin 956a7be048 Merge pull request #126 from tgoodlet/firstresult_wrapper_mention 6334e37c41 Mention that wrappers are still invoked when using `firstresult` 36d0d717b0 Merge pull request #124 from jwilk-forks/spelling 91e38d286f Fix typos 6486ee8811 Document PluginValidationError.plugin 54248d5a72 Add .plugin member to PluginValidationError to access failing plugin ab415994d5 Merge pull request #119 from tgoodlet/test_proc_is_none dcde058f93 Avoid calling None in call_historic cc223378a1 Test historic hook with no callback 91b2193f09 Merge pull request #118 from tgoodlet/docs_ref_fix 32ee0e0512 Merge pull request #117 from tgoodlet/split_into_modules 2100bbf5c5 Minor version bump for development 0a959f8fa6 Expose proper public imports and fix tests to match bfc2ae3597 Move hook execution tracer to tracing module dfedf4a6ca Move hook internals to a seperate module 3f1eda532d Re-package such that tests work 8984e86069 Move package file to `pluggy.manager` d2e19a4f9f move tracer to own file 316cc6a8c2 Fix docs references 50d6626188 Merge pull request #115 from anthrotype/fix-docs-typos 9cbd220e47 docs/index.rst: typos [skip ci] 13eee878e7 Merge pull request #113 from anthrotype/fix-docs-typos a8ae202fb2 docs/index.rst: fix minor typo f36d2db46c Merge pull request #112 from anthrotype/fix-docstring e587897dcc remove reference to missing 'excludefunc' arg in PluginManager docstring 843d4b93e3 Stamp 0.6.0. minor release git-subtree-dir: tools/third_party/pluggy git-subtree-split: b1b07a309653a42a5311810f71d0addd09a4ec81
Hexcles
added a commit
that referenced
this pull request
Dec 15, 2020
b1b07a3096 manual changelog entry 742f4705fb Preparing release 0.13.1 39a6d69031 tox: release: use python3 a5130ac87a Merge pull request #232 from kinow/patch-1 9890e90f6d Merge pull request #236 from hoefling/master d5b871dee3 fixed wrong refs by class name in PluginManager docstring 0e57e28df2 updated broken links due to acc name change ca1ddebd3b added cross-referencing in docstrings, some formatting improvements 7f5213ea9a fixed broken links, added missing refs in apidoc, using intersphinx where possible fe5a72bc92 Merge pull request #234 from asottile/release-0.13.0 93a6b83769 Preparing release 0.13.0 5b7aba1a83 Fix simple typo: specfication -> specification (#233) c8872e2b23 Fix simple typo: specfication -> specification 4d546fe479 Add the output of the example code e40a877135 Merge pull request #226 from bluetech/simplify-tracing 4497278ec2 Avoid an intermediary variable 14e9d85ca5 Merge pull request #229 from blueyed/tox-py 12133da6cb test_pluginmanager: use pluggy.manager.metadata 2ef0090917 tox.ini: make "tox -e py37" etc work 8900b4c09e Do the string joining already inside _format_message() 1be7c25235 Improve name tag2proc -> tags2proc f0535d2683 Reduce scope of except to avoid masking exceptions 1f8fdd861c Remove unhelpful _HookRelay._trace indirection a05bdd56e1 Mark a few things on TagTracer private 92e72be06e Remove TagTracerSub.setmyprocessor 69c3255f7e Inline _TracedHookExecution a1c6c3526c Merge pull request #224 from bluetech/fixes1 95dd65f538 Fix call_historic() example in index.rst 0194e630c6 Remove broken test 92c31e159b Don't confusingly reuse a variable name inside varnames() b2ffeb9962 Fix error case return type of varnames() 8aa5592b53 Replace importlib_metadata with importlib.metadata on Python 3.8+ (#223) 1bf30d695d Update tests matrix to reflect recent changes in pytest 763b661fc1 Workaround pytest-dev/pytest#5523 c66077d8c0 Replace importlib_metadata with importlib.metadata on Python 3.8+ 57b2a6dc15 Merge pull request #216 from asottile/release-0.12.0 a878c473a6 Preparing release 0.12.0 69deb13c16 importlib-metadata again (#215) 94ab205d21 Require a newer version of importlib-metadata which supports eggs b0f3b6d616 Revert "Merge pull request #206 from asottile/revert-199-importlib_metadata_v2" 7f8f8eb442 Merge pull request #214 from nicoddemus/revert-signature 4e728aa40a Revert varnames() refactor to use inspect.Signature d4d45c9190 Fix a regression with keyword only arguments (#213) bebd02418f Fix a regression with keyword only arguments f8108d791f Convert hooks.varnames() to inspect.signature() on Python 3 (#210) 39c6247294 Add CHANGELOG for #209 2008a3d5d1 Check for funcsigs using sys.version_info 0a7fec29cf Add testing for py38 on Travis 68e56e553d Separate function for unbound method detection 62f28acac8 Use funcsigs on Python 2 6504cb358a Use --force-reinstall when installing tox 04ef19308e Update setuptools and pip before installing tox ec28f02718 Convert hooks.varnames() to inspect.signature() on Python 3 f8af26cb31 Use src-layout (#203) c86cc29a79 Update support files for new src layout b46ac5f7a3 Move pluggy -> src 8e34a1ff71 fixup release script (#207) 68c8a2e421 Merge pull request #208 from asottile/release-0.11.0 e28defcbcf fixup release script e85335cbb0 Preparing release 0.11.0 07f44342e8 Merge pull request #206 from asottile/revert-199-importlib_metadata_v2 2b06ab4d96 Add changelog 45b64240dc Revert "Switch to importlib-metadata" d7a9792412 Fix CHANGELOG for 0.10.0 (#204) 6469325373 Fix CHANGELOG for 0.10.0 895b564505 Preparing release 0.10.0 (#202) 97262e812c Preparing release 0.10.0 f4eb6b426a Add changelog for #199 (#201) f1f2e3c7bd skip installation in linting env b1d68ba0cf Add changelog for #199 8749791ccd Switch to importlib-metadata (#199) 4de9e440ee Merge pull request #200 from asottile/fix_pre_commit_config 0706fbaa70 Invoke tox directly (?) f282a42a22 Expose the ImportError / AttributeError to the caller 66b2a1308a pre-commit autoupdate + fix config e387587986 Fix test for DistFacade 491cefe688 Add a Facade to pretend to be pkg_resources 9550fc30e0 Switch to importlib-metadata 59b3cf284a Merge pull request #197 from blueyed/cov 1af417351a Merge branch 'master' into cov cbd4e3ae25 Merge pull request #198 from blueyed/cfg 29c1a969d9 doc fix: is_blocked 4223913f11 tox.ini: pytest: addopts, testpaths e654da4094 ci: Travis: dist=xenial e0ad955475 Setup coverage reporting [skip appveyor] 70cb026433 ci: Travis: cache for pre-commit 4ea971188c Merge pull request #196 from jakobkogler/doc_classname_example_fix ee26b8d628 Fix class name of plugin in example 4f98685510 Merge pull request #195 from jakobkogler/docstring_typo 52c98abcf6 Fix method name `add_hookspecs` in docstring 3ef4ff87ea Merge pull request #194 from ingwinlu/patch-1 086784741b Add eggsample setup.py 1874468e21 Fix typo 758c00dc94 Merge pull request #193 from nicoddemus/skip-tests-on-deploy 61f67e05b4 Merge pull request #192 from nicoddemus/release-0.9.0 f32dee0d40 Skip tests when deploying b6a6c721a6 Preparing release 0.9.0 3c384dd377 Merge pull request #189 from nicoddemus/early-load-4718 9a12ad43ac Merge pull request #188 from nicoddemus/pypy3 0e0f0544b4 Fix internal varnames function for PyPy3 893b546aab Ignore 'pip-wheel-metadata' dir generated by pip 1d6b381d05 Add name parameter to PluginManager.load_setuptools_entrypoints 666bb4b9a9 Add testing for pypy3 cfba99d3ad Merge pull request #184 from nicoddemus/release-0.8.1 d0471e8f4a Merge pull request #185 from tgoodlet/sidebar_again a2939c044b Add html local toc sidebar to docs 317e99212f Preparing release 0.8.1 b40bcd8af9 Merge pull request #181 from crazymerlyn/change_implprefix_warning_stacklevel 72ee32f592 Merge pull request #179 from nicoddemus/skip-deploy-without-tags 2724a58a73 Merge pull request #182 from nicoddemus/update-conda-badge 3e21bfea86 Use conda-forge badge instead of anaconda 22d4417bdf Merge pull request #180 from nicoddemus/release-0.8.0 bee289c9b8 Adjust stacklevel of implprefix warning 758fd7cc04 Preparing release 0.8.0 38988e9471 Merge pull request #177 from Sup3rGeo/feature/get-plugins-for-hook f0d6f87a2a Only generate 'deploy' jobs on Travis when a tag is present a5c17ec664 Simplify asserts in test_get_hookimpls 21dec08835 Added comment to make order importance more explicit. c85f15449c Inverted order, needed for calls. e1fcf6041e Refactored to use get_hookimpls() ca0d07136e Fixed test. 163ff505cd Moved get_hookimpl to HookCaller. 17783a5504 Updated docstring. 5e1ee9552f Fixed test. bcd551d76d Added get_hookimpl with test. 1da70c931b Merge pull request #57 from tgoodlet/encapsulate_specs c967e91814 Add trivial entry 894b5e2599 Encapsulate spec definitions with a class 3a79b527f8 Merge pull request #172 from tgoodlet/test_opt_in_args 429c5fc052 Add a test demonstrating the opt in nature of args 96e94e5fb7 Merge pull request #173 from nicoddemus/plugin-count 96543a5394 Update number of pytest plugins in the docs 6587ed0d0e Merge pull request #169 from nicoddemus/pre-commit-black 9940cf2a4a Remove extra newlines at the end of files 98ae198625 Commit black-docs 2e87aefb6e Add blacken-docs pre-commit hook 851a02d5af Add black badge to README e413c70d01 Change "check" tox env to "linting" which runs pre-commit c253ce2e74 Run pre-commit in all files a07b424929 Add dev dependencies and pre-commit configuration 962d67432d Merge pull request #167 from nicoddemus/fix-changelog bccc385b9b Merge pull request #168 from fschulze/changelog 669315c835 Add changelog in long package description and documentation. Fixes #165. 5d37d7a351 Normalize all titles and add dates in CHANGELOG e601df4325 Merge pull request #160 from nicoddemus/release-0.7.0 9b48efb3f9 Run towncrier manually and fix changelog manually 72e4c2597e Fix error when handling VersionConflict exceptions from setuptools entry points 1b09518483 Merge pull request #162 from pytest-dev/nicoddemus-patch-1 94333258b0 Merge pull request #161 from gitter-badger/gitter-badge c1f661658c Merge pull request #163 from pytest-dev/pluggy-changelog-titles 8b95e0ff36 Fix Gitter badge 53af86d380 Use "pluggy" in changelog title d044159483 Skip AppVeyor when deploying 9555f4fd56 Add Gitter badge 20685531ad Preparing release 0.7.0 b607b01532 Change release command to call git directly b22cf1c244 Change #131 and #66 changelog entries to trivial 8294801d6d Merge pull request #158 from tgoodlet/newsfragments 1ad161e801 Add newsfragments for 0.7.0 release! 887951a231 Merge pull request #157 from nicoddemus/towncrier 7161f97856 Fix URL in changelog template 0fa7d9e521 Use towncrier and a custom tox environment to prepare a release dad903c4ac Merge pull request #156 from blueyed/repr df14939f50 fixup! Add HookImpl.__repr__ f05da83967 Add HookImpl.__repr__ 76232fa360 Merge pull request #153 from tgoodlet/tests_reorg dbda5aa884 Move deprecation warnings tests to a module 8573118599 Document the manager module b093f9eec0 Move manager related tests to proper module 32a02876ab Move hookcaller test to appropriate module 4c19d8da3d Rename some test modules cab120f63e Merge pull request #144 from tgoodlet/deprecate_implprefix 77578ad572 Expect deprecation warnings throughout tests 39f2136ee8 Add deprecation test 49968c25c9 Deprepate `implprefix` arg to `PluginManager` aeb1f673f3 Merge pull request #143 from tgoodlet/deprecate_proc_arg 0faf6cb669 Document result_callback arg 6b296c23f9 Deprecate `proc` kwarg to call_historic() 88fe9b9ca3 Merge pull request #142 from tgoodlet/doc_self_arg eed63e0f09 Fix typo in RuntimeError f47d9d6f1e Aggregate hyperlinks e54fc41595 Document exception handling c5a50d6c04 Point to warehouse 645cef3587 Note that `self` is ignored in hookimpl signatures 119836b53a Merge pull request #136 from Avira/elevator-pitch a20a6670c1 Improve the output and make clearer, why we do what we do in docs. e84fdfa07a fix bug in example and some more improvements/clarfications. 653a1e9bed Implement the suggestions by @tgoodlet 115f1fca63 fix phrasing and formatting. d2baceeeaf fix class name c2286a9ce6 work in fixes, suggestions from review deb62e6950 Merge pull request #139 from nicoddemus/travis-deploy ffe2caad9f fix link to devpi docs - thanks @fschulze! 6283b3b9d2 Rework the docs intro and add another example 2b39339980 optimize vertical space 9f4f954bb2 Document how to release pluggy 8029ab004d Use setuptools_scm to automatically version the package on tags 56e6ce01ee Use travis to deploy from travis to PyPI on tags e778f7a3ca Merge pull request #138 from RonnyPfannschmidt/hook-warn-defined a400a2cb9f support adding per implementation warnings for hookspecs a58b8b0fba rework of docs after discussion fb2f96c168 Merge pull request #137 from MarSoft/patch-1 e51039deb2 make knowledge part explicit b59e917135 Fix typo in docstring 5b77f41f12 introduce line breaks 0381424c15 remove redundancy 2f6831b0b0 fix grammar 26f8a94d37 change some formulations and add some links fcdc245333 high level description of pluggy by using roles e57c82a7c6 Merge pull request #129 from nicoddemus/fix-self-docs 140d6b54a2 Add missing 'self' parameter to hookimpl in docs 366946a9b0 Merge pull request #122 from ids1024/PluginValidationError-plugin 2a2c97193e Add test for PluginValidationError.plugin 956a7be048 Merge pull request #126 from tgoodlet/firstresult_wrapper_mention 6334e37c41 Mention that wrappers are still invoked when using `firstresult` 36d0d717b0 Merge pull request #124 from jwilk-forks/spelling 91e38d286f Fix typos 6486ee8811 Document PluginValidationError.plugin 54248d5a72 Add .plugin member to PluginValidationError to access failing plugin ab415994d5 Merge pull request #119 from tgoodlet/test_proc_is_none dcde058f93 Avoid calling None in call_historic cc223378a1 Test historic hook with no callback 91b2193f09 Merge pull request #118 from tgoodlet/docs_ref_fix 32ee0e0512 Merge pull request #117 from tgoodlet/split_into_modules 2100bbf5c5 Minor version bump for development 0a959f8fa6 Expose proper public imports and fix tests to match bfc2ae3597 Move hook execution tracer to tracing module dfedf4a6ca Move hook internals to a seperate module 3f1eda532d Re-package such that tests work 8984e86069 Move package file to `pluggy.manager` d2e19a4f9f move tracer to own file 316cc6a8c2 Fix docs references 50d6626188 Merge pull request #115 from anthrotype/fix-docs-typos 9cbd220e47 docs/index.rst: typos [skip ci] 13eee878e7 Merge pull request #113 from anthrotype/fix-docs-typos a8ae202fb2 docs/index.rst: fix minor typo f36d2db46c Merge pull request #112 from anthrotype/fix-docstring e587897dcc remove reference to missing 'excludefunc' arg in PluginManager docstring 843d4b93e3 Stamp 0.6.0. minor release git-subtree-dir: tools/third_party/pluggy git-subtree-split: b1b07a309653a42a5311810f71d0addd09a4ec81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.