-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove printing/ test #23453
Remove printing/ test #23453
Conversation
This test ends up spawning a print dialog in non-Blink based browsers, which causes an unnecessary test timeout. It also doesn't seem to match a requirement in the HTML spec, and the description of the test doesn't seem to match its actual behaviour.
There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
I agree with your analysis, but given we can ping the author perhaps @chrishtr can chime in. |
I sent @chrishtr an email a couple of days ago, but didn't hear back. But you're right that I should also have pinged them here. The TC failure is just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave it up to you then.
I will write a Chromium CL that moves the test out of that directory and into a Chromium-specific one. Please don't delete this test just now, it adds test coverage for Chromium. |
This is because there is no spec text corresponding to this behavior, and the test is failing on other browsers. See also: #23453 Change-Id: Ia2d4f0c75c3b295e19f1ffec3e2e0d0fb1882c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187174 Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#766471}
This is because there is no spec text corresponding to this behavior, and the test is failing on other browsers. See also: #23453 Change-Id: Ia2d4f0c75c3b295e19f1ffec3e2e0d0fb1882c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187174 Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#766471}
This is because there is no spec text corresponding to this behavior, and the test is failing on other browsers. See also: web-platform-tests/wpt#23453 Change-Id: Ia2d4f0c75c3b295e19f1ffec3e2e0d0fb1882c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187174 Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#766471}
My CL landed. You can abandon this PR. |
For the record, #23464 is the Chromium export that removed these files. |
Automatic update from web-platform-tests Move a printing test out of WPT This is because there is no spec text corresponding to this behavior, and the test is failing on other browsers. See also: web-platform-tests/wpt#23453 Change-Id: Ia2d4f0c75c3b295e19f1ffec3e2e0d0fb1882c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187174 Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#766471} -- wpt-commits: 928a59a1f593450900c3a9f820c656b101f072c2 wpt-pr: 23464
Automatic update from web-platform-tests Move a printing test out of WPT This is because there is no spec text corresponding to this behavior, and the test is failing on other browsers. See also: web-platform-tests/wpt#23453 Change-Id: Ia2d4f0c75c3b295e19f1ffec3e2e0d0fb1882c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187174 Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#766471} -- wpt-commits: 928a59a1f593450900c3a9f820c656b101f072c2 wpt-pr: 23464
Automatic update from web-platform-tests Move a printing test out of WPT This is because there is no spec text corresponding to this behavior, and the test is failing on other browsers. See also: web-platform-tests/wpt#23453 Change-Id: Ia2d4f0c75c3b295e19f1ffec3e2e0d0fb1882c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187174 Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#766471} -- wpt-commits: 928a59a1f593450900c3a9f820c656b101f072c2 wpt-pr: 23464
Automatic update from web-platform-tests Move a printing test out of WPT This is because there is no spec text corresponding to this behavior, and the test is failing on other browsers. See also: web-platform-tests/wpt#23453 Change-Id: Ia2d4f0c75c3b295e19f1ffec3e2e0d0fb1882c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187174 Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#766471} -- wpt-commits: 928a59a1f593450900c3a9f820c656b101f072c2 wpt-pr: 23464
This test ends up spawning a print dialog in non-Blink based browsers,
which causes an unnecessary test timeout. It also doesn't seem to match
a requirement in the HTML spec, and the description of the test doesn't
seem to match its actual behaviour.