Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registerProtocolHandler(): handler's URL cannot be a blob URL #23500

Merged
merged 3 commits into from
May 11, 2020
Merged

registerProtocolHandler(): handler's URL cannot be a blob URL #23500

merged 3 commits into from
May 11, 2020

Conversation

annevk
Copy link
Member

@annevk annevk commented May 11, 2020

No description provided.

@annevk annevk requested a review from saschanaz May 11, 2020 08:35
annevk added a commit to whatwg/html that referenced this pull request May 11, 2020
@annevk
registerProtocolHandler(): only "https" schemes for the handler
f650111 
Tests: web-platform-tests/wpt#23500.
@annevk annevk mentioned this pull request May 11, 2020
Merged
3 tasks
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-23500 May 11, 2020 08:39 Inactive
saschanaz
saschanaz approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

While you are at it, could you double check Line 62? I think it should be using unregisterProtocolHandler.

@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-23500 May 11, 2020 09:31 Inactive
@annevk annevk merged commit 409d250 into master May 11, 2020
@annevk annevk deleted the annevk/registerProtocolHandler-blob branch May 11, 2020 10:17
domenic pushed a commit to whatwg/html that referenced this pull request May 11, 2020
@annevk @domenic
registerProtocolHandler(): only "https" schemes for the handler
72a6f17 
Tests: web-platform-tests/wpt#23500.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschanaz saschanaz saschanaz approved these changes

@domenic domenic Awaiting requested review from domenic

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zcorpan zcorpan Awaiting requested review from zcorpan

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@zcorpan zcorpan

Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annevk @saschanaz @zcorpan @wpt-pr-bot