Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Taskcluster] Make lint create a GitHub Checks output file #24556

Merged
merged 5 commits into from
Sep 9, 2020
Merged

[Taskcluster] Make lint create a GitHub Checks output file #24556

merged 5 commits into from
Sep 9, 2020

Conversation

stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Jul 10, 2020 •
edited
Loading

See #15412

@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 July 10, 2020 13:31 Inactive
jgraham
jgraham reviewed Jul 10, 2020
View reviewed changes
Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super excited to see this happening!

tools/ci/tc/decision.py Outdated Show resolved Hide resolved
tools/lint/lint.py Outdated Show resolved Hide resolved
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 July 28, 2020 13:21 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 August 4, 2020 20:19 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 August 4, 2020 23:22 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 August 4, 2020 23:57 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 August 5, 2020 02:53 Inactive
@stephenmcgruer stephenmcgruer marked this pull request as ready for review August 5, 2020 11:22
@stephenmcgruer stephenmcgruer changed the title [WIP] Make lint spit out GitHub CheckRun output file [Taskcluster] Make lint create a GitHub Checks output file Aug 5, 2020
@stephenmcgruer
Copy link
Contributor Author

Ok, this is ready for review. The MyPy types aren't great, but I'm not 100% happy with the code anyway (seems a bit bolted-on) so didn't want to over-invest in fixing them until we are sure this is the right approach.

@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 August 5, 2020 11:25 Inactive
Hexcles
Hexcles reviewed Aug 14, 2020
View reviewed changes
tools/ci/tc/github_checks_output.py Outdated Show resolved Hide resolved
tools/lint/lint.py Outdated Show resolved Hide resolved
tools/lint/lint.py Show resolved Hide resolved
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 August 14, 2020 19:54 Inactive
@wpt-pr-bot wpt-pr-bot added the wptrunner The automated test runner, commonly called through ./wpt run label Aug 14, 2020
@wpt-pr-bot wpt-pr-bot had a problem deploying to wpt-preview-24556 August 14, 2020 20:03 Error
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 August 14, 2020 20:10 Inactive
Hexcles
Hexcles approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % a nit

tools/ci/tc/github_checks_output.py Show resolved Hide resolved
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 August 14, 2020 20:30 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24556 August 17, 2020 11:18 Inactive
@stephenmcgruer
Copy link
Contributor Author

Ping @Hexcles @jgraham for re-review.

jgraham
jgraham approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ with nits (notably reverting the example change, and a comment for the Any usage).

dom/interface-objects.html Outdated Show resolved Hide resolved
@stephenmcgruer stephenmcgruer merged commit 8420fdf into master Sep 9, 2020
@stephenmcgruer stephenmcgruer deleted the lint-output-md branch September 9, 2020 14:52
@stephenmcgruer stephenmcgruer mentioned this pull request Sep 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham approved these changes

@annevk annevk Awaiting requested review from annevk

@jdm jdm Awaiting requested review from jdm

@LukeZielinski LukeZielinski Awaiting requested review from LukeZielinski

@zqzhang zqzhang Awaiting requested review from zqzhang

@Hexcles Hexcles Awaiting requested review from Hexcles

Assignees

@jgraham jgraham

Labels
ci dom infra lint wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephenmcgruer @jgraham @Hexcles @wpt-pr-bot @moz-wptsync-bot