Direct Sockets: stub implementations for openTCPSocket openUDPSocket #25199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 22, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2366395
branch
7 times, most recently
from
abf59d9
to
988f08b
Compare
The rename is tentative, blocked on naming decision WICG/direct-sockets#10 Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/ARtkaw4e9T4/m/npjeMssPCAAJ Design doc: https://docs.google.com/document/d/1Xa5nFkIWxkL3hZHvDYWPhT8sZvNeFpCUKNuqIwZHxnE/edit?usp=sharing We introduce IDL methods for opening TCP and UDP sockets. We introduce a mojom service that will perform permission checks before forwarding socket opening requests to the Network Service. Not yet implemented: Permissions checks, calls to Network Service Bug: 909927 Change-Id: Ifec9860d4e0b8211af7b142b856efc29cd6f9b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366395 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Glen Robertson <glenrob@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#802210}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2366395
branch
from
988f08b
to
1cda315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rename is tentative, blocked on naming decision
WICG/direct-sockets#10
Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md
Intent to Prototype:
https://groups.google.com/a/chromium.org/g/blink-dev/c/ARtkaw4e9T4/m/npjeMssPCAAJ
Design doc:
https://docs.google.com/document/d/1Xa5nFkIWxkL3hZHvDYWPhT8sZvNeFpCUKNuqIwZHxnE/edit?usp=sharing
We introduce IDL methods for opening TCP and UDP sockets.
We introduce a mojom service that will perform permission checks
before forwarding socket opening requests to the Network Service.
Not yet implemented:
Permissions checks, calls to Network Service
Bug: 909927
Change-Id: Ifec9860d4e0b8211af7b142b856efc29cd6f9b35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366395
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802210}