Remove anonymous box from details/summary shadow dom #26053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 8, 2020
3 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2462217
branch
from
9766781
to
82c6532
Compare
Previously, there was an anonymous <div> in the shadow dom for the <summary> element, which caused display:contents to not behave in an interoperable way. See [1] for a spec PR that clarifies the spec, and this CL matches the new clarification. The new WPT added here passes already on Gecko and WebKit. [1] whatwg/html#4746 Fixed: 973074 Change-Id: Iba54616c4e54e357dd71b7de30de18bde8ff3983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462217 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by: Oriol Brufau <obrufau@igalia.com> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#815731}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2462217
branch
from
82c6532
to
167f83c
Compare
annevk
added a commit
to whatwg/html
that referenced
this pull request
Oct 12, 2020
As is evident from https://bugs.chromium.org/p/chromium/issues/detail?id=973074 the current description still had too much from the old description and led to some inconsistencies in implementations. This makes it clear the slots have no special styling (by default) and it's the first summary element that is special, not the first slot. Tests: web-platform-tests/wpt#26053.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was an anonymous <div> in the shadow dom for the
<summary> element, which caused display:contents to not behave in an
interoperable way. See [1] for a spec PR that clarifies the spec,
and this CL matches the new clarification.
The new WPT added here passes already on Gecko and WebKit.
[1] whatwg/html#4746
Fixed: 973074
Change-Id: Iba54616c4e54e357dd71b7de30de18bde8ff3983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462217
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Oriol Brufau <obrufau@igalia.com>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815731}