[WPT] Migrate most of import-maps resolution tests out of blink internals #26064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 9, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2457526
branch
from
2bd9d65
to
b48153c
Compare
…nals This CL migrates most of import maps resolution tests by observing the resolution results by intercepting module script requests by a service worker. This CL also introduces `useInternalMethods` flag to clarify the tests still requiring internal methods. Bug: 1026809 Change-Id: I16c2a87bb67b530dc97b1631f6968b2d3bafdac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457526 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#818366}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2457526
branch
from
b48153c
to
ee9971b
Compare
This was referenced Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL migrates most of import maps resolution tests by
observing the resolution results by intercepting
module script requests by a service worker.
This CL also introduces
useInternalMethodsflag to clarifythe tests still requiring internal methods.
Bug: 1026809
Change-Id: I16c2a87bb67b530dc97b1631f6968b2d3bafdac6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457526
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818366}