HTML: the condition for opening a popup by window.open, and BarProp values for each case #28243
+151
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham and
zqzhang
Merged
3 tasks
annevk
approved these changes
Mar 26, 2021
| @@ -0,0 +1,15 @@ | |||
| <script src="/common/PrefixedPostMessage.js"></script> | |||
There was a problem hiding this comment.
This is neat, didn't know about this.
annevk
reviewed
Apr 20, 2021
...-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html
Outdated
Show resolved
Hide resolved
arai-a
force-pushed
the
window-open-features
branch
from
2677196
to
7c2c947
Compare
arai-a
force-pushed
the
window-open-features
branch
2 times, most recently
from
796dac4
to
12ebca4
Compare
|
Is there any rule about how many new windows single test can open? the current test opens ~50 new windows, I wonder if it's better splitting it in order to reduce the time taken by single test file. |
|
There are no rules. See https://web-platform-tests.org/writing-tests/testharness.html#variants for what you probably want to use if you go down this route. |
…alues for each case For whatwg/html#5872 and whatwg/html#4431
arai-a
force-pushed
the
window-open-features
branch
from
12ebca4
to
85ce509
Compare
domenic
approved these changes
Oct 28, 2021
|
|
||
| <!-- user agents are not required to support open features other than `noopener` | ||
| and on some platforms position and size features don't make sense --> | ||
| <meta name="flags" content="may" /> |
There was a problem hiding this comment.
I think user agents are required to support everything in this test now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatwg/html#5872 and whatwg/html#4431