Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This CL adds functionality that correctly handles network error of Subresource Web Bundles. #28617

Merged
merged 1 commit into from
Apr 23, 2021

Commits on Apr 23, 2021

  1. This CL adds functionality that correctly handles network error of

    Subresource Web Bundles.
    
    The problem is: when Web Bundle fetching fails due to a network error,
    Subresource fetch doesn't fail forever.
    One such case (subresource-loading-cors-error test) was
    timing out previously but passes successfully with this change.
    
    This CL also adds 2 WPT tests:
    1. subresource-loading-network-error.https.tentative.sub.html
    2. subresource-loading-web-bundle-fetch-failed.https.tentative.html
    
    Test #1 is a scenario with a different network error than the CORS
    one, but with the same issue of subresource fetching timing out
    without the change. It passes successfully after the change.
    
    Test #2 is a scenario with a Web bundle not found error, which is
    not directly influenced by the code added in this CL, but it expands
    the test coverage which was found to be lacking the error cases before.
    
    Bug: 1168449
    
    Change-Id: Ia3abb967e36274becc86e317bc51b1272d3ae679
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826001
    Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Miras Myrzakerey <myrzakereyms@google.com>
    Cr-Commit-Position: refs/heads/master@{#875532}
    myrzakereyms authored and chromium-wpt-export-bot committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    94765f1 View commit details
    Browse the repository at this point in the history