Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test history.push/replaceState() with no URL + document.open() #28826

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Test history.push/replaceState() with no URL + document.open() #28826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions ...arkup-insertion/opening-the-input-stream/url-impact-on-history-pushreplacestate.window.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
async_test(t => {
const frame = document.body.appendChild(document.createElement("iframe"));
t.add_cleanup(() => frame.remove());

frame.onload = t.step_func_done(() => {
// Per discussion in https://github.com/whatwg/html/issues/6556 and related threads, this will change the document's
// URL, but will *not* update the session history entry's URL.
frame.contentDocument.open();
assert_equals(frame.contentDocument.URL, document.URL, "Precondition: the URL gets changed");

frame.contentWindow.history.pushState(null, "");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a long time to realize that this passes null as URL. (I should maybe have read the commit message first.)

So the idea is that the fallback for pushState() is the document's URL.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, the third parameter is the URL, and it's not passed at all.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but that defaults to null through IDL.

assert_equals(frame.contentDocument.URL, document.URL, "pushState() must set the URL to the document's current URL");
});

frame.src = "/common/blank.html";
}, "pushState() must use the document's current URL (which document.open() sets), not the session history entry's current URL (which it doesn't)");

async_test(t => {
const frame = document.body.appendChild(document.createElement("iframe"));
t.add_cleanup(() => frame.remove());

frame.onload = t.step_func_done(() => {
// Per discussion in https://github.com/whatwg/html/issues/6556 and related threads, this will change the document's
// URL, but will *not* update the session history entry's URL.
frame.contentDocument.open();
assert_equals(frame.contentDocument.URL, document.URL, "Precondition: the URL gets changed");

frame.contentWindow.history.replaceState(null, "");
assert_equals(frame.contentDocument.URL, document.URL, "replaceState() must set the URL to the document's current URL");
});

frame.src = "/common/blank.html";
}, "replaceState() must use the document's current URL (which document.open() sets), not the session history entry's current URL (which it doesn't)");