[WebTransport] Check event type before using its properties #31036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The below code is problematic
if self._session_stream_id == event.stream_id and\
isinstance(event, WebTransportStreamDataReceived):
because it uses event's property before checking its type. This
leads to errors when event without stream_id comes here. This
change fixes that.
yutakahirano
requested review from
nidhijaju
and removed request for
bashi,
jgraham and
foolip
|
@nidhijaju can you take a look? |
foolip
approved these changes
Sep 30, 2021
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
…form-tests#31036) The below code is problematic if self._session_stream_id == event.stream_id and\ isinstance(event, WebTransportStreamDataReceived): because it uses event's property before checking its type. This leads to errors when event without stream_id comes here. This change fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The below code is problematic
if self._session_stream_id == event.stream_id and
isinstance(event, WebTransportStreamDataReceived):
because it uses event's property before checking its type. This
leads to errors when event without stream_id comes here. This
change fixes that.