Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for abortSignal.throwIfAborted(); #31947

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Tests for abortSignal.throwIfAborted(); #31947

merged 3 commits into from
Dec 8, 2021

Conversation

jasnell
Copy link
Contributor

@jasnell jasnell commented Dec 7, 2021

@wpt-pr-bot wpt-pr-bot added the dom label Dec 7, 2021
@wpt-pr-bot wpt-pr-bot requested review from annevk, jdm and zqzhang December 7, 2021 23:07
@jasnell jasnell mentioned this pull request Dec 7, 2021
Merged
3 tasks
annevk
annevk reviewed Dec 8, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add a test with a primitive value as reason?

dom/abort/event.any.js Outdated Show resolved Hide resolved
@domenic @annevk
Use assert_throws_exactly
dba846f 
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
domenic
domenic approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this file is no longer just about the event, so really should be split up into multiple files, but that's a preexisting issue so let's merge this first and then split up or rename later if we care.

@domenic
Copy link
Member

domenic commented Dec 8, 2021

Oh, I missed @annevk's suggestion to do a primitive value as the reason. I don't think it's really necessary but I lean toward more coverage rather than less so let's do it, before we merge.

@jasnell
Copy link
Contributor Author

jasnell commented Dec 8, 2021

Added the additional primitive check

@domenic domenic merged commit b03df35 into web-platform-tests:master Dec 8, 2021
annevk pushed a commit to whatwg/dom that referenced this pull request Dec 10, 2021
@domenic
Introduce abortSignal.throwIfAborted()
cfe2f1e 
Tests: web-platform-tests/wpt#31947.

Closes #927.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

@domenic domenic domenic approved these changes

@jdm jdm Awaiting requested review from jdm

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@zqzhang zqzhang

Labels
dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @domenic @annevk @zqzhang @wpt-pr-bot