[CSP] Enhance unsafe-eval test to check both realms #32898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 18, 2022
This was referenced Feb 18, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3472768
branch
2 times, most recently
from
b1f1074
to
6fed256
Compare
When checking whether eval is allowed, only CSPs of the calleeRealm should be checked. Change-Id: I89d3f3f2352dc63538b8479b058f44c12e9ede1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3472768 Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/main@{#973509}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3472768
branch
from
6fed256
to
88adfae
Compare
antosart
added a commit
to w3c/webappsec-csp
that referenced
this pull request
Feb 23, 2022
According to WPTs web-platform-tests/wpt#32898, Firefox, Safari and Chrome only check policies of the calleeRealm for determining if eval is allowed. Discussions on #438 explain why it is probably hopeless to correctly check the callerRealm. This change adapt the spec to adhere the vendors' implementation, and only check calleeRealm.
ryandel8834
added a commit
to ryandel8834/WebAppSec-CSP
that referenced
this pull request
Aug 13, 2022
According to WPTs web-platform-tests/wpt#32898, Firefox, Safari and Chrome only check policies of the calleeRealm for determining if eval is allowed. Discussions on #438 explain why it is probably hopeless to correctly check the callerRealm. This change adapt the spec to adhere the vendors' implementation, and only check calleeRealm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking whether eval is allowed, only CSPs of the calleeRealm
should be checked.
Change-Id: I89d3f3f2352dc63538b8479b058f44c12e9ede1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3472768
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/main@{#973509}