Add a few cases to preload SRI #33326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Thanks! I want to reach a consensus on whatwg/fetch#1418 before merging. |
3 tasks
See whatwg/html#7655 When loading video from multiple opaque origins (by a middleman service-worker), video loading should fail rather than be alllowed and taint the canvas. That's because some of the video responses may contain metadata such as duration that would leak to the subsequent requests. See whatwg/html#2814 (comment) for further details. This change makes the test case pass in all browsers.
hiroshige-g
reviewed
Mar 24, 2022
hiroshige-g
reviewed
Mar 24, 2022
hiroshige-g
reviewed
Mar 24, 2022
hiroshige-g
reviewed
Mar 24, 2022
hiroshige-g
reviewed
Apr 1, 2022
| SRIPreloadTest( | ||
| true, | ||
| false, | ||
| `Same-origin ${destination} with non-matching digest reuses preload with no digest but fails.`, |
There was a problem hiding this comment.
"does not reuse preload"? (as Line 350 is "2")
|
sorry for delay, LGTM (with a minor comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two cases don't show the same results across browsers.
Note that in webkit most of the tests in this file currently fail, WebKit does not perform SRI matching on preload/consume.
The test results in this PR match chromium, but they are not necessarily "correct".