Support CSS Conditional 5 font feature detection extensions #35829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 8, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3197710
branch
2 times, most recently
from
aee3593 to
c63cbf1
Compare
[1] defines two additional conditional functions `font-tech()` and `font-format()` which were introduced after the resolution of TAG review [2] and discussion in the CSS working group [3]. These functions allow conditional CSS to be included depending on level of font support in the font stack of the UA. Feature detection becomes particular important when checking for the level of color font support, as UA capabilities still very and not all user agents provide support for COLRv1 for example. Implement behind `SupportsFontFormatTech` RuntimeEnabledFeatures flag for now, pending I2S. [1] https://www.w3.org/TR/css-conditional-5/#at-supports-ext [2] w3ctag/design-reviews#666 [3] w3c/csswg-drafts#6520 (comment) Bug: 1255685 Change-Id: I96ab292bc9644b049a84e073b367063cdbedd26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197710 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1046434}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3197710
branch
from
c63cbf1 to
b56c8c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1] defines two additional conditional functions
font-tech()andfont-format()which were introduced after the resolution of TAG review[2] and discussion in the CSS working group [3].
These functions allow conditional CSS to be included depending on level
of font support in the font stack of the UA. Feature detection becomes
particular important when checking for the level of color font support,
as UA capabilities still very and not all user agents provide support
for COLRv1 for example.
Implement behind
SupportsFontFormatTechRuntimeEnabledFeatures flagfor now, pending I2S.
[1] https://www.w3.org/TR/css-conditional-5/#at-supports-ext
[2] w3ctag/design-reviews#666
[3] w3c/csswg-drafts#6520 (comment)
Bug: 1255685
Change-Id: I96ab292bc9644b049a84e073b367063cdbedd26f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197710
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1046434}