Add ImageDecoder-independent animated AVIF test
#36044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasbynens
commented
Sep 23, 2022
Using `step_timeout` instead, as recommended by the linter, makes the test time out.
``` ffmpeg -loglevel error -hide_banner -f lavfi -i color=green:2x2 -frames:v 1 -y /tmp/green.avif ```
mathiasbynens
force-pushed
the
animated-avif
branch
from
49d5c12
to
6f2cab7
Compare
The `animated-avif.avif` and `green.avif` files are generated as follows: ```sh ffmpeg -loglevel error -hide_banner -f lavfi -i color=red:2x2 -frames:v 1 -y /tmp/red.png; ffmpeg -loglevel error -hide_banner -f lavfi -i color=green:2x2 -frames:v 1 -y /tmp/green.png; avifenc --duration 1 /tmp/red.png --duration 1800 /tmp/green.png /tmp/animated-avif.avif; avifenc --duration 1 /tmp/green.png /tmp/green.avif; ```
mathiasbynens
force-pushed
the
animated-avif
branch
from
6f2cab7
to
d1fcc1a
Compare
This reverts commit d1fcc1a.
|
https://wpt.fyi/results/animated-avif/animated-avif-timeout.html?label=pr_head&max-count=1&pr=36044 shows a failure for Firefox. With only 4 pixels being different, it can't be that the red frame is still showing. Can you check what's going on? |
foolip
reviewed
Sep 30, 2022
Why not? The image is 2×2 px, Firefox doesn’t support animated AVIF yet, so I would expect the red frame to show. |
|
Aha, didn't know it was a 2x2 image. I assumed a 100x100 or something. |
foolip
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. web-platform-tests/interop#136