Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new dialog shadow focus behavior #36498

Merged
merged 1 commit into from
Nov 5, 2022

Commits on Nov 5, 2022

  1. Implement new dialog shadow focus behavior

    This implements the new dialog initial focus behavior specified in these
    changes:
    whatwg/html#7079
    whatwg/html#7284
    whatwg/html#7361
    whatwg/html#8174
    
    The gist of the changes are:
    1. Use the DOM tree instead of the flat tree to search for an element to
       give initial focus.
    2. Don't traverse into shadow roots when looking for elements to give
       initial focus unless the shadow root has delegatesFocus.
    
    This will stay experimental until I have also made the other changes for
    dialog initial focus: whatwg/html#8199
    After those changes have been made as well, I will carefully enable the
    flag by default.
    
    Fixed: 383230, 670130, 1292852
    Change-Id: I13995197f1942aa356cab0f3b41a0e226d1d170d
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3961528
    Reviewed-by: Mason Freed <masonf@chromium.org>
    Commit-Queue: Joey Arhar <jarhar@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1067796}
    josepharhar authored and chromium-wpt-export-bot committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    e3a9b47 View commit details
    Browse the repository at this point in the history