Reland "Implement new dialog shadow focus behavior" #36851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 7, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4009903
branch
from
73b0f66
to
8138184
Compare
Original change: http://crrev.com/c/3961528 Revert: http://crrev.com/c/4005547 The original change was reverted due to tests failing on some mac bots. This happened due to a leftover platform specific baseline which didn't get tested in CQ+1. This reland removes that baseline which will make those bots pass. Fixed: 383230, 670130, 1292852 Change-Id: If024ab0f22716c55b439e44b2298e39897ee844e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4009903 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1068779}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4009903
branch
from
8138184
to
f14c01d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original change: http://crrev.com/c/3961528
Revert: http://crrev.com/c/4005547
The original change was reverted due to tests failing on some mac bots.
This happened due to a leftover platform specific baseline which didn't
get tested in CQ+1. This reland removes that baseline which will make
those bots pass.
Fixed: 383230, 670130, 1292852
Change-Id: If024ab0f22716c55b439e44b2298e39897ee844e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4009903
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1068779}