Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[popover][anchor-position] Implement implicit anchoring (2/2) #37129

Merged
merged 1 commit into from
Dec 1, 2022

Commits on Dec 1, 2022

  1. [popover][anchor-position] Implement implicit anchoring (2/2)

    - https://drafts.csswg.org/css-anchor-1/#implicit-anchor-element
    - josepharhar/html#2
    
    This is the 2/2 patch implementing implicit anchoring for popovers,
    focusing on layout-level changes.
    
    With the info of which elements are used as implicit anchors, this
    patch adds the implicit anchors into NG*AnchorQuery with LayoutObject
    as keys, so that implicit anchor queries can be evaluated without an
    anchor name.
    
    At a more detailed level, now all the NG*AnchorQuery classes need to
    maintain two hashmaps: one keyed by names for the named anchors, and
    the other keyed by LayoutObjects for the implicit anchors. To reduce
    code verbosity, the common structure of these classes is abstracted
    into a base class NGAnchorQueryBase.
    
    Bug: 1307772, 1380112
    Change-Id: I9bdec5e3c08f9b9b20442503dedf32995643f037
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4053342
    Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1078270}
    xiaochengh authored and chromium-wpt-export-bot committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    cb35dde View commit details
    Browse the repository at this point in the history