Subset URL tests by file/javascript/mailto schemes #37372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for all browsers this seems to (surprisingly) increase the total number of tests:
|
|
@gsnedders there should be some increase, as there's both harness status and "Loading data…" tests contributing to the denominator. There are 7 tests that were turned into 4 variants each, which adds 7*3 = 21. That matches the delta seen. |
wpt-pr-bot
requested review from
annevk,
domenic,
GPHemsley,
mikewest and
TimothyGu
foolip
commented
Dec 15, 2022
| var key = expected.input.split(":")[0]; | ||
| return key; | ||
| } | ||
| return "other"; |
There was a problem hiding this comment.
It's important that the key isn't falsey, otherwise it'll be included in all test variants.
foolip
commented
Dec 15, 2022
foolip
commented
Dec 15, 2022
foolip
commented
Dec 15, 2022
foolip
commented
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.