Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rendering tests for the <search> element #39163

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Add rendering tests for the <search> element #39163

merged 1 commit into from
Mar 24, 2023

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Mar 23, 2023

This was referenced Mar 23, 2023
Merged
Open
annevk
annevk approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that both of these fail in existing user agents, right?

@zcorpan
Copy link
Member Author

zcorpan commented Mar 24, 2023

Yes: https://wpt.fyi/results/html/rendering/non-replaced-elements/flow-content-0?sha=8d463a2d30&label=pr_head

@domenic domenic merged commit c49cf0a into master Mar 24, 2023
@domenic domenic deleted the zcorpan/search-element-rendering branch March 24, 2023 01:55
@domenic domenic mentioned this pull request Dec 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@domenic domenic Awaiting requested review from domenic

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@domenic domenic

Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zcorpan @annevk @domenic @wpt-pr-bot