Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that console is a namespace #3994

Merged
merged 2 commits into from
Oct 18, 2016
Merged

Test that console is a namespace #3994

merged 2 commits into from
Oct 18, 2016

Conversation

domenic
Copy link
Member

@domenic domenic commented Oct 17, 2016

@domenic
Copy link
Member Author

domenic commented Oct 17, 2016

Passes in Firefox and Safari Tech Preview. Chrome fails the propdesc test, and Edge fails a lot of tests.

We need owners (i.e. reviewers) for this new top-level directory. Here is a list of people who have been involved in various issue threads:

Reply if you would like to become a reviewer for console web platform tests, and if so I'll add you to an owners file. Also, as your first act as a reviewer, maybe review these tests :)

@pwnall
Copy link
Contributor

pwnall commented Oct 17, 2016

I'd like to become a reviwer.

@pwnall
Copy link
Contributor

pwnall commented Oct 17, 2016

Would you consider making this an .html test, so I can pretend it's a layout test and debug it easily in Chromium? 😄

If you're willing to go down that route, here is an example, and can you please put the spec URLs in link tags with rel="help"?

@domenic
Copy link
Member Author

domenic commented Oct 17, 2016

I'd rather keep it environment-agnostic if possible :). I put the spec links in comments at the top because yeah, with the .any.js setup, there is no good place for that.

You should be able to debug in Chrome with http://w3c-test.org/submissions/3994/console/console-is-a-namespace.any.html though :)

I filed https://monorail-prod.appspot.com/p/chromium/issues/detail?id=656826 BTW.

@pwnall
Copy link
Contributor

pwnall commented Oct 17, 2016

Thank you for explaining, LGTM.

If you add me to the repository, I can merge your tests.

@domenic
Copy link
Member Author

domenic commented Oct 17, 2016

Awesome \o/. Let me ping the repo owners about adding you.

@zcorpan
Copy link
Member

zcorpan commented Oct 18, 2016

I've invited @pwnall as a collaborator.

@pwnall pwnall merged commit fbe5ac0 into master Oct 18, 2016
@pwnall
Copy link
Contributor

pwnall commented Oct 18, 2016

Thank you very much for this opportunity, @domenic and @zcorpan!

@zcorpan zcorpan deleted the console-namespace branch October 19, 2016 06:51
@robertkowalski
Copy link

a bit late -- thanks <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants