Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FedCM] Add testdriver support for FedCM #40006

Merged
merged 15 commits into from
May 25, 2023
Merged

Conversation

tttzach
Copy link
Contributor

@tttzach tttzach commented May 15, 2023

Adds testdriver support for Federated Credential Management (FedCM)
Link to spec PR: w3c-fedid/FedCM#465

@tttzach
Copy link
Contributor Author

tttzach commented May 17, 2023

We're under the impression that we wouldn't need an RFC because this is a straightforward implementation of web driver commands but feel free to let us know if that's not the case. Thanks for reviewing!

@tttzach tttzach marked this pull request as ready for review May 17, 2023 16:38
@tttzach tttzach requested a review from a team as a code owner May 17, 2023 16:38
@wpt-pr-bot wpt-pr-bot added docs infra testdriver.js wptrunner The automated test runner, commonly called through ./wpt run labels May 17, 2023
@sideshowbarker sideshowbarker removed their request for review May 18, 2023 05:45
@foolip
Copy link
Member

foolip commented May 24, 2023

We're under the impression that we wouldn't need an RFC because this is a straightforward implementation of web driver commands but feel free to let us know if that's not the case. Thanks for reviewing!

That's right, https://fedidcg.github.io/FedCM/#automation is all you need, per the exception in https://github.com/web-platform-tests/rfcs#when-to-use-the-rfc-process.

resources/testdriver.js Outdated Show resolved Hide resolved
resources/testdriver.js Outdated Show resolved Hide resolved
resources/testdriver.js Outdated Show resolved Hide resolved
tools/wptrunner/wptrunner/executors/actions.py Outdated Show resolved Hide resolved
resources/testdriver.js Outdated Show resolved Hide resolved
@tttzach tttzach requested a review from foolip May 25, 2023 04:35
@tttzach
Copy link
Contributor Author

tttzach commented May 25, 2023

Please take another look, @foolip :)

@foolip foolip merged commit daf050c into web-platform-tests:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs infra testdriver.js wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants