Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 2 border-image-repeat tests and removed border-image-[ 15 | 16 ].html #40731

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Added 2 border-image-repeat tests and removed border-image-[ 15 | 16 ].html #40731

merged 1 commit into from
Aug 16, 2023

Conversation

TalbotG
Copy link
Contributor

@TalbotG TalbotG commented Jun 23, 2023

This is a last followup-to Pull Request 8788

At my website:

http://www.gtalbot.org/BrowserBugsSection/CSS3Backgrounds/border-image-repeat-round-stretch-001.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Backgrounds/reference/border-image-repeat-round-stretch-001-ref.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Backgrounds/border-image-repeat-stretch-round-001.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Backgrounds/reference/border-image-repeat-stretch-round-001-ref.html

I believe we should remove
http://wpt.live/css/css-backgrounds/border-image-15.html

I also believe we should remove
http://wpt.live/css/css-backgrounds/border-image-16.html

  • because the git-committed-added tests above are pixel-accurate (border-image-source has no oblique line and no curvy shapes, only rectangular lines therefore I expect no antialias subpixel fuzziness), reliable and trustworthy tests on border-image-repeat: [ round stretch | stretch round ] and
  • because border-image-16.html does not have any reference (both J. Patonnier et C. Nardi did not make any)

@TalbotG TalbotG requested review from frivoal and fantasai June 23, 2023 19:48
@TalbotG TalbotG self-assigned this Jun 23, 2023
@wpt-pr-bot wpt-pr-bot requested a review from dbaron June 23, 2023 19:48
@dbaron dbaron removed their request for review June 23, 2023 20:26
@fantasai fantasai merged commit 87a439b into web-platform-tests:master Aug 16, 2023
@TalbotG TalbotG deleted the CSS3Backgrounds-GT-PR49 branch August 16, 2023 17:27
OrKoN pushed a commit that referenced this pull request Aug 17, 2023
@TalbotG @OrKoN
Added 2 border-image-repeat tests and removed 2 (#40731)
b25b602 
border-image-16 is covered by reftest css3-border-image-repeat-stretch.html
border-image-15 is covered by reftest border-image-repeat-space-011.html and others
whimboo pushed a commit that referenced this pull request Aug 22, 2023
@TalbotG @whimboo
Added 2 border-image-repeat tests and removed 2 (#40731)
f5b58c7 
border-image-16 is covered by reftest css3-border-image-repeat-stretch.html
border-image-15 is covered by reftest border-image-repeat-space-011.html and others
@TalbotG TalbotG mentioned this pull request Aug 23, 2023
Merged
@foolip foolip mentioned this pull request Sep 22, 2023
Closed
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this pull request Dec 11, 2023
@TalbotG @Lightning00Blade
Added 2 border-image-repeat tests and removed 2 (web-platform-tests#4…
c99b09b 
…0731)

border-image-16 is covered by reftest css3-border-image-repeat-stretch.html
border-image-15 is covered by reftest border-image-repeat-space-011.html and others
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantasai fantasai fantasai approved these changes

@frivoal frivoal Awaiting requested review from frivoal

Assignees

@TalbotG TalbotG

Labels
css-backgrounds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TalbotG @fantasai