-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Source Phase Imports for ESM Integration #42467
[wasm] Source Phase Imports for ESM Integration #42467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be rewritten as a .any.js
file which will make this also runnable from Web Workers and Service Workers.
Can it? Note |
I've split out the tests to separate the module source constructor tests from the HTML ones, so they should work across different contexts. I've also extended the ESM integration HTML worker test to include source phase imports. PTAL |
8e1e061
to
9c2a61f
Compare
Co-authored-by: Nicolò Ribaudo <hello@nicr.dev>
ed9b9d0
to
4565832
Compare
This adds a test for the new source phase imports aspect of the ESM integration.
Includes tests both for using the source phase, and for checking that the prototype behaviours match the updated requirements on
WebAssembly.Module
extendingAbstractModuleSource
.Per the note in https://github.com/WebAssembly/esm-integration#es-module-integration-proposal-for-webassembly, it is possible for implementations to implement source phase imports independently from non-source-phase imports. I don't know if there's a way we want to reflect that in the test structure though?