Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccName: comp_labelledby tests #42522

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook commented Oct 13, 2023

Closes web-platform-tests/interop-accessibility#35

Some follow-on work is blocked by w3c/accname#209 so additional tests will come in web-platform-tests/interop-accessibility#68

@cookiecrook cookiecrook self-assigned this Oct 13, 2023
@cookiecrook cookiecrook changed the title self-referencial labelledby + another IDREF AccName: comp_labelledby tests Oct 13, 2023
@cookiecrook
Copy link
Contributor Author

Adding @chrishtr as a reviewer, who may also be able to comment why an unrelated ChromeDriver download failure blocks the required sink-task. Am I reading the logs correctly?

tools.wpt.browser.DownloadNotFoundError: No ChromeDriver download found to match browser version 120.0.6062.2 dev

@cookiecrook
Copy link
Contributor Author

Recycling CI

@cookiecrook cookiecrook reopened this Oct 16, 2023
@cookiecrook cookiecrook removed the request for review from chrishtr October 16, 2023 23:24
Comment on lines +40 to +45
BLOCKED on https://github.com/w3c/accname/issues/209

Once that's resolved, it may be worthwhile to add a new ./comp_labelledby_recursion.html file,
so that the implementation diffs rolling in don't penalize this Interop 2024 test.

All remaining cases of https://w3c.github.io/accname/#comp_labelledby
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewers: Some follow-on work is blocked by w3c/accname#209 so additional tests will come separately in web-platform-tests/interop-accessibility#68

@rahimabdi rahimabdi self-requested a review October 25, 2023 16:02
Copy link
Contributor

@rahimabdi rahimabdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cookiecrook cookiecrook merged commit 73ddc2a into web-platform-tests:master Nov 3, 2023
19 checks passed
@cookiecrook cookiecrook deleted the comp_labelledby branch November 3, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AccName: tests/todos in accname/name/comp_labelledby
3 participants