Add tests for aria-owns and hiding techniques in assorted scenarios
#44822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adampage, I think you can mark this a "ready for review" because I'm guessing no one has taken a look yet since it is still draft :) |
|
Thanks, @spectranaut 😅 — done. |
wpt-pr-bot
requested review from
cookiecrook,
jnurthen,
MelSumner and
spectranaut
cookiecrook
reviewed
Aug 19, 2024
| <p><span id="child-simulated">Bold text with a yellow background</span> is the target of another element’s <code>aria-owns</code>.</p> | ||
|
|
||
| <h2>Child is moved, nothing is hidden</h2> | ||
| <p>Expected: <q>I love cats and dogs I like birds</q></p> |
There was a problem hiding this comment.
This PR warps my brain. I think we might need a working session to review the intentions here. A few things that might make the PR easier to review are:
- expected values that are more relevant to the function than random cat/dog/bird strings... Perhaps "[rendered contents owning][rendered owned contents that is child of aria-hidden parent]" or something that indicates the expectation and why you expect it.
- more functional or less contrived examples (to the extent possible), that should obviously work according to an authors intention.
| <p>Expected: <q>I love cats and dogs I like birds</q></p> | ||
| <button | ||
| class="ex-label" | ||
| data-testname="Child is moved, nothing is hidden" |
There was a problem hiding this comment.
Updates to the test name might also lend clarity. It's difficult to understand the expectations from the CI results comparison page too.
There was a problem hiding this comment.
e.g. why does the "Child is moved, nothing is hidden" test expect "I love cats and dogs I like birds"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion tests for ARIA PR #1839: Clarify relationship between
aria-hiddenandaria-owns.In development of that PR, I created a Codepen to manually test a few different scenarios involving combinations of
aria-owns,aria-hidden, and host language hiding techniques.This PR is my attempt to translate those scenarios into roughly comparable WPT tests. In the Codepen, I rendered a bunch of
genericelements and manually tested their exposure in the accessibility tree as static text nodes.In porting those scenarios into to this PR, I decided to leverage WPT’s
get_computed_label()function and considered two markup testing approaches: name from author and name from content.I chose name from content and tweaked each of my markup scenarios to use a parent
buttonelement, then compared my expected label to whatever accname was assembled for thebuttonfrom its contents (involving a bunch of inneraria-owns,aria-hidden, anddisplay: none;nonsense).