Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a variant test for script scheduling #47018

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a variant test for script scheduling #47018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions html/semantics/scripting-1/the-script-element/execution-timing/128.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<script src="testlib/testlib.js"></script>
</head>
<div id="log"></div>
<p>This test is similar to <a href="151.html">151.html</a>, but here the parent script is flagged as non-parser-inserted in "prepare the script element" because it is empty.</p>
<script>
var t = async_test();
</script>
Expand Down
29 changes: 29 additions & 0 deletions html/semantics/scripting-1/the-script-element/execution-timing/151.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<!DOCTYPE html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, you might want to see https://github.com/web-platform-tests/wpt/blob/master/dom/nodes/insertion-removing-steps/Node-appendChild-script-in-script.tentative.html. It's related to whatwg/dom#1261 and whatwg/html#10188, and once the latter lands, I think we'll need a different set of expectations corresponding with the simpler spec.

In fact, I'm wondering if we don't even need the test in this PR once we make the existing one I linked to above, non-tentative. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one you linked to is basically the same as 128, right, in that it relies on the parser-inserted script s1 being unflagged as parser-inserted? So I think this variant still has some small but nonzero value compared to either of them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think this variant still has some small but nonzero value compared to either of them.

Yep, that may well address the point about whether we should remove this test or not. But I still think it could be good to update the expectations to match what we're pursuing in HTML regarding script scheduling + children changed events.

<html><head>
<title>scheduler: appending script element to non-parser-inserted script</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="testlib/testlib.js"></script>
</head>
<div id="log"></div>
<p>This test is similar to <a href="128.html">128.html</a>, but here the parent script is non-parser-inserted all along.</p>
<script>
var t = async_test();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need an async test here right? Can we just do this all in a sync test?

t.step(function() {
log("inline script #1");
var script = document.createElement("script");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something other than var here and below?

document.body.appendChild(script);

var frag = document.createDocumentFragment();
frag.appendChild(document.createTextNode("t.step(function() {log('inline script #2');\n"));
frag.appendChild(document.createElement("script")).textContent = "t.step(function() {log('inline script #3');});"
frag.appendChild(document.createTextNode("log('end inline script #2');})"));

script.appendChild(frag);
log("end inline script #1");
});

onload = t.step_func_done(function() {
assert_array_equals(eventOrder, ["inline script #1", "inline script #3", "inline script #2", "end inline script #2", "end inline script #1"]);
});
</script>