Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RemoteContextHelper to open windows from remote contexts #48159

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 13, 2024

There will be multiple tests in followup CLs that will need to open
windows from existing windows and frames. This will allow to simplify those tests.

Example usage: https://crrev.com/c/5841474

Bug: 340606651
Bug: b/365144247
Change-Id: I47f4d8c473fe69bc72e2c9345c0d5825451431e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5838815
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Reviewed-by: Ari Chivukula <arichiv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1355331}

There will be multiple tests in followup CLs that will need to open
windows from existing windows and frames. This will allow to simplify those tests.

Example usage: https://crrev.com/c/5841474

Bug: 340606651
Bug: b/365144247
Change-Id: I47f4d8c473fe69bc72e2c9345c0d5825451431e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5838815
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Reviewed-by: Ari Chivukula <arichiv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1355331}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@WeizhongX
Copy link
Contributor

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test | Subtest | Results | Messages -- | -- | -- | -- /html/browsers/browsing-the-web/history-traversal/document-state.https.html |   | OK: 1/10, TIMEOUT: 9/10 |   /html/browsers/browsing-the-web/history-traversal/document-state.https.html | A navigation's initiator origin and referrer are stored in the document state and used on location.reload() | PASS: 1/10, TIMEOUT: 9/10 | Test timed out

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.


@WeizhongX
Copy link
Contributor

@jcscottiii jcscottiii merged commit ffc8a3a into master Sep 14, 2024
16 of 18 checks passed
@jcscottiii jcscottiii deleted the chromium-export-cl-5838815 branch September 14, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants