Add a pip constraints file for our entire dependency tree #48947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbf5d49 bumped the version of Sphinx, and in doing so broke the ability to build the docs on Python 3.8, which in theory we still support. To avoid changing the version we actually use when deploying our website, keep the current version pinned for 3.9, and introduce a new, lower, pin for older Python versions (i.e., 3.8).
This ensures that we have a single set of requirements for everything we depend on, and avoids risks of mutually incompatible updates occuring.
This hasn't been needed since 7eed90b, so we should just drop it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids problems such as #33015 where our unpinned (recursive) dependencies broke things for us, and moves us towards having deterministic Python environments.
Starting this as a draft because this does rather break dependabot, and it does really require
uvto generate theconstraints.txtfile (because, unlikepip-tools'spip-compile, it supports a--universalflag which allows it to generate a constraint file that works everywhere).We should probably start trying to tidy up many of what this leaves as
requirements*.infiles to only include direct dependencies, and then we can probably try to start to bump the versions we're using.