-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python packages cbor2 and pyhpke to third party tools #49598
base: master
Are you sure you want to change the base?
Add python packages cbor2 and pyhpke to third party tools #49598
Conversation
What error are you avoiding by doing that? Both |
I got this error:
|
Oh, right. agronholm/cbor2@d9cee77 made the change here to drop Python 3.8 support, but that commit doesn't appear in any release. Is there a reason why we're pulling in the current Relatedly, can you please add to the commit message what versions are being imported, such that anyone in the future could replicate this? |
Good point, are you suggesting that I should import the version which still supports python 3.8? |
Revert cbor2 to release 5.6.5 and I have verified that this version works well with WPT. |
@gsnedders is your question all addressed? can you pls approve this one? |
Add new python packages
cbor2
andpyhpke
totools/third_party
for Google Chrome WPT support. This change is based on the discussion of web-platform-tests/rfcs#208.Note for cbor2, the imported version is release 5.6.5 which is the last version to support python 3.8 in Web Platform Tests.
cbor2: https://github.com/agronholm/cbor2
pyhpke: https://github.com/dajiaji/pyhpke