Deprecate and remove web bundle directFromSellerSignals #49713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6096602
branch
from
5eab31c to
0032f10
Compare
The header-based version of directFromSellerSignals (directFromSellerSignalsHeaderAdSlot) is unaffected. Also, adds a WPT negative test, and uses a feature flag to control the removal. Usage metrics for web-bundle directFromSellerSignals are extremely low [0]. I2D&R thread [1]. [0] https://chromestatus.com/metrics/feature/timeline/popularity/5034 [1] https://groups.google.com/a/chromium.org/g/blink-dev/c/t9gHiTwV370 Bug: 384481095 Change-Id: I36d6ba9dbbeef4c434d00f5ba61cb1696bfbe11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6096602 Reviewed-by: Mike Taylor <miketaylr@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1400484}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6096602
branch
from
0032f10 to
811d561
Compare
wpt-pr-bot
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header-based version of directFromSellerSignals
(directFromSellerSignalsHeaderAdSlot) is unaffected.
Also, adds a WPT negative test, and uses a feature flag to control the
removal.
Usage metrics for web-bundle directFromSellerSignals are extremely low [0].
I2D&R thread [1].
[0] https://chromestatus.com/metrics/feature/timeline/popularity/5034
[1] https://groups.google.com/a/chromium.org/g/blink-dev/c/t9gHiTwV370
Bug: 384481095
Change-Id: I36d6ba9dbbeef4c434d00f5ba61cb1696bfbe11d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6096602
Reviewed-by: Mike Taylor <miketaylr@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1400484}